Custom themes about loungedestroyer HOT 15 CLOSED

i vote aye

from loungedestroyer.

aye.

but too lazy to make themes.

from loungedestroyer.

I'll make theme handler, you write .css files

from loungedestroyer.

How I and @birjolaxew plan to make it:

• Offer users to load a custom theme
  • Users could load the .css manually through a file or a URL, or just copy paste it
  • Provide auto-updating for themes
• Meta-data block in .css files that gives ability for developers to have auto-updatable themes, specify version number of it and compability
• Remove any styling hardcoded in the HTML (CSGL devs keep doing that with some elements)
• No JavaScript stuff, only CSS
• Ask community to make themes, best ones will be bundled with LoungeDestroyer while still allowing community to load their own themes

from loungedestroyer.

Almost done with this. Only thing left to do is the auto-updating of remote themes. We're going to need some themes to ship with it initially - anyone up for creating a few?

from loungedestroyer.

Themes is a quite a step for this extension but it is still not polished, few things still needed:

• Need to check if there are any possibilities of exploits
• Add option for removing inline styling on site
• Add option for removing site .css styling completely

Also we need to make sure elements that are added by extension can be styled properly (have a class name for every added element type).

At the moment 'Preview' button seems to be heavily broken (which is partially added by us and the site itself).

Should probably add some classes to to reflect what page is it, some might want to style stuff only for specific pages.

Also how does styling prioritize with extension styling?

from loungedestroyer.

Theme styling is injected last, and as such has a higher priority than everything else.

I've been thinking of creating classes to indicate whether the theme is dark/light, which page it is, etc. Gonna work on that now.

Removing of styles can be handled in-theme, using a simple CSS reset. If you feel like adding it as an option, send me the CSS to implement, and I'll get it done.

from loungedestroyer.

$(document).ready(function(){
       document.head.appendChild(style);
});

Lol, wut @birjolaxew, why you are not using chrome.tabs.insertCSS? The way you do it, user sees for a split second the CSGL style before extension appends the style.

from loungedestroyer.

Because chrome.tabs.insertCSS has the lowest priority possible, meaning all extensions would require !important for every. single. value.

from loungedestroyer.

When you select a theme from the <select>, the selected theme on the slider doesn't update. Also fix height change responsiveness issue with the slider.

from loungedestroyer.

Some weird shit is happening if I clone farblood's theme in /themes folder.

from loungedestroyer.

Inatead of parsing the theme stylesheet everytime user refreshes a page, why not parse it once on theme update/selection and store it in a variable? Or is that already the case?

from loungedestroyer.

That's already the case.

from loungedestroyer.

Reminder of themes workflow:

Our hand-picked themes that are going to be bundled with extension should not be bundled in folder /themes. They should be remote bundled, because we do not want to release an update to app store every time a theme creator updates their themes that is bundled with our extension.

Users and theme creators still should be able to manually add themes through /themes folder, and the themes should work, unlike now, they do not. If I clone @FarBlood's theme, it does not work.

Remote bundle the themes, specify the URLs somewhere for each bundled theme. http://api.ncla.me/themes/

Perhaps get rid of the absolute URLs for each individual part of theme (css, icon, bg) and just specify the directory. http://api.ncla.me/themes/CleanLounge/

Local themes (that are in /themes folder) and remote themes should be injected in the site the same way, read from Chrome storage the parsed theme stylesheet.

from loungedestroyer.

Empty slider

from loungedestroyer.