canopy heat storage not scaled by vegetation fraction about noahmp HOT 7 CLOSED

Hello,
What is the modification to the line so that we could fix it in our implementation?
Thank you

from noahmp.

I'm still working in the non-refactored code, so this is the proposed fix. Didn't want to put in a PR until I could get something working with refactored code (don't know when that will be).

Related to this line in the non-refactored code:

 ! canopy heat capacity
-        hcv = fveg*(parameters%cbiom*vaie*cwat + canliq*cwat/denh2o + canice*cice/denice) !j/m2/k
+        hcv = parameters%cbiom*vaie*cwat + canliq*cwat/denh2o + canice*cice/denice !j/m2/k

from noahmp.

This is indeed a bug. I will fix it in the GitHub develop and master branch as well as the version 4.5 used in WRFv4.5.

from noahmp.

The canopy heat storage term needs to be scaled by vegetation fraction (FVEG) because all the other heat flux terms in the energy balance calculations are scaled by FVEG.

from noahmp.

I am closing this issue based on the above discussions.

from noahmp.

@cenlinhe @tslin2 for future reference there should be a way to automatically close the issue when the PR is merged.

from noahmp.

I believe if you put the following in your commit message as part of the PR, the issue will automatically close when the PR is merged into the main branch:

Resolves: #[issue number]

See the example commit message here:
https://cbea.ms/git-commit/#seven-rules

from noahmp.