forward_operator mod checking for MISSING_R8 values rather than looking at the istatus. about dart HOT 1 CLOSED

hkershaw added a comment - 28/Jan/16 2:21 PM
I think this can just be stripped out of the forward operator.
It is left over from obs_space_diagnostic code that is now in the forward operator.

hkershaw added a comment - 28/Jan/16 2:21 PM
I think this can just be stripped out of the forward operator.
It is left over from obs_space_diagnostic code that is now in the forward operator.

hkershaw added a comment - 29/Jan/16 4:22 PM
This patched on the cam_fv branch. However, after consulting with Nancy and Johnny, I am going to fix this on the trunk and move these tests into obs_space_diag.

hkershaw added a comment - 08/Feb/16 9:02 AM
Fix committed to trunk in commit 9726

Kevin Raeder added a comment - 09/May/17 4:40 PM
I have a note that I'm supposed to look into this issue.
Helen wrote that it's fixed, and I see no MISSING_R8 in tag 11289:
assimilation_code/modules/observations/forward_operator_mod.f90
so I believe that it is resolved and can be closed.

Nancy Collins added a comment - 01/Aug/17 1:30 PM
this is no longer a bug about istatus. the code works correctly.

cam may still have code to return good obs values with a bad istatus code.
no one can get to those values and it complicates the logic in the model_mod.
the code would be simpler if it just failed and returned as soon as the istatus is going to be non-zero.

from dart.