Comments (11)
Yeah, isFake() works for both store
and store.session
. If isFake()
returns true, you can assume that that storage (local or session) is unsupported for that browser (or browser mode).
As for preventing things from even being stored in local memory when using fake storage... that's a bit antithetical to the design, but i'm fairly sure you could monkey patch things to make that happen seamlessly. Let me think on the best way to do that for you...
from store.
I just did a test on safari (Version 8.0.6 (10600.6.3)) in private browsing mode and isFake() did not return false. Is that a bug? Because in private browsing mode, localStorage is not allowed.
from store.
Thanks for the offer above, I will see what I can do about memory storage.
from store.
I think the following would do the trick. If the targeted storage area is fake (not supported), it just refuses to store anything.
/**
* Copyright (c) 2015 ESHA Research
* Dual licensed under the MIT and GPL licenses:
* http://www.opensource.org/licenses/mit-license.php
* http://www.gnu.org/licenses/gpl.html
*
* Store nothing when storage is not supported.
*
* Status: ALPHA - due to being of doubtful propriety
*/
;(function(_) {
var _set = _.set;
_.set = function(area, key, string) {
return area.isFake() ? undefined : _set.apply(this, arguments);
};
})(window.store._);
from store.
Waow, thanks. But please do look at the isFake() returning false on private browsing mode in safari. It should return true.
from store.
Reopening while i consider again the perpetual headache of Safari private mode...
from store.
LOL. There is another store.js library on Github and it was checking if storage is enabled by trying to write and then read from the localStorage. Maybe you guys can do something like that too to ensure.
from store.
The problem with Safari private is that the storage API is provided but throws quota errors, which is exceedingly foolish. I could maybe forgive that if getItem were at least functional (i.e. you could save something in localStorage on non-private, then at least read it in private mode), but it's not. Useless. More fake than my in-memory fake storage.
Ok, enough kvetching. Back to thinking about solutions...
from store.
This is what that other library did
var testKey = '__storejs__';
store.set(testKey, testKey);
if (store.get(testKey) != testKey) { store.disabled = true; }
store.remove(testKey);
So, you may use something like that to test. Trying to write to and read from local storage would be the best way to ensure it is writeable.
from store.
Okay, version 2.3.0 is out and uses fake storage for Safari private mode. It also includes a store.onlyreal.js (which is a fixed version of the code i posted above). Thanks for being a squeaky wheel; i think this is a good move.
from store.
LOL. Thank you for the fix!
from store.
Related Issues (20)
- TypeScript complains that area doesn't exists HOT 8
- 同学,您这个项目引入了319个开源组件,存在14个漏洞,辛苦升级一下 HOT 1
- Ability to change the delimiter? HOT 12
- this is literally a convoluted JSON.parse/JSON.stringify HOT 1
- Cache expires value always undefined HOT 5
- version 2.14.0 is not published to npm HOT 3
- expiration time HOT 1
- Bug: error TS2304: Cannot find name 'index' HOT 1
- Q: Is there any way to bypass JSON.stringfy on .set() HOT 4
- How to get the store namespace value? HOT 1
- How to write .d.ts for extension method(s)? HOT 1
- Is there anyway to obtain what storage I'm passing to the plugin? HOT 2
- How much capacity for storage? HOT 1
- _.replace does not get rich objects HOT 4
- Is this library MIT or GPL-3? HOT 1
- GPL-3 or MIT? HOT 5
- Error in each implementation HOT 3
- Question: Are browser native storage APIs supported? HOT 2
- TypeScript Definitions Issue HOT 21
- store怎么在vue3中使用? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from store.