Comments (15)
ppegusii
commented on June 19, 2024
I get the following error when trying to get the BrowserFS example working using localstorage.
{"type":1,"code":"ENOENT","message":"/: No such file or directory."}
This is the HTML document.
<!DOCTYPE html>
<html>
<head>
<!--<script src="compiled/lib/jquery-2.1.1.min.js" type="text/javascript"></script>-->
<!--
<script data-main="release/interpret-pyc" src="node_modules/requirejs/require.js"></script>
-->
<script src="compiled/lib/browserfs.min.js" type="text/javascript"></script>
</head>
<body>
<h1>Python Interpreter Test</h1>
<input type="file" onchange="handleFiles(this.files)"></input>
<div id='out'>
</div>
<script type="text/javascript">
BrowserFS.install(window);
var lsfs = new BrowserFS.FileSystem.LocalStorage();
BrowserFS.initialize(lsfs);
var fs = require('fs');
fs.writeFile('/sample.txt', 'Testing!', function(err){
if(err){ console.log(JSON.stringify(err)); }
});
/*
function handleFiles(fileList){
console.log(fileList[0]);
var reader = new FileReader();
reader.onload = (function(theFile){
return function(pyc){
console.log(pyc);
console.log(theFile.name);
console.log(pyc.target.result);
BrowserFS.install(window);
var lsfs = new BrowserFS.FileSystem.LocalStorage();
BrowserFS.initialize(lsfs);
var fs = require('fs');
fs.writeFile('test.txt', 'Testing!', function(err){
if(err){ console.log(err); }
});
//fs.writeFile('/'+theFile.name, pyc.target.result, function(err){
// if(err){ console.log(err); }
//});
};
})(fileList[0]);
reader.readAsBinaryString(fileList[0]);
}
*/
</script>
</body>
</html>from ts-python-interpreter.
jvilk
commented on June 19, 2024
I just tried this with browserfs.min.js from 0.3.5, and... that code works with no modifications!
One weird possibility is that local storage contains garbage data. Can you try flushing it with localStorage.clear() to see if this fixes the issue?
from ts-python-interpreter.
jvilk
commented on June 19, 2024
(Built code located here: https://github.com/jvilk/BrowserFS/releases/tag/v0.3.5 )
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
localStorage.clear() fixed the problem. Thanks!
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
I'm using FileReader.readAsText(File) on a file uploaded from an <input type="file"></input> tag. That method of FileReader should use UTF-8 encoding. I attach a handler to the onload event of the FileReader which receives a ProgressEvent. In that handler, I write to localstorage using BrowserFS's fs.writeFile('filename', ProgressEvent.target.result, 'utf8', cb). The problem is I seem to be using incorrect character encodings or the wrong readAs... method of FileReader. I've tried some other readAs... and fs.writeFile encoding combinations, but can't find one that works.
from ts-python-interpreter.
jvilk
commented on June 19, 2024
utf8 should be the string to identify UTF-8 encoding. utf is ambiguous, as there's utf8, utf16, and utf32.
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
Sorry that was a typo. I did specify 'utf8'.
from ts-python-interpreter.
jvilk
commented on June 19, 2024
Have you opened the debugger and verified that result is a string? What's the error? (Chrome DevTools are quite useful for this sort of thing.)
from ts-python-interpreter.
jvilk
commented on June 19, 2024
Oh, and I should mention:
fs.writeFile('filename', ProgressEvent.target.result, 'utf8', cb)This states, "take the input JavaScript string, and write it to a file in UTF-8 format". So if it's not a JavaScript string, it won't work.
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
I have verified that result is a string with typeof. The error occurs during parsing. Python Marshal prefixes serialized objects with a utf8 character that indicates the type of the object that follows. When parsing, the parser reads a utf8 character from the file that is not in the set of type characters. This does not happen when running the parser in node on the same pyc file.
from ts-python-interpreter.
jvilk
commented on June 19, 2024
Python Marshal prefixes serialized objects with a utf8 character that indicates the type of the object that follows.
What error are you getting? Where is it getting thrown? Are you trying to write a binary file using UTF-8 encoding? Not all bytes are valid UTF-8 characters, and my UTF-8 encoding function verifies that it is not writing invalid characters. (EDIT: With that said, if it's already a JavaScript string (which are UTF-16), then... maybe there's a bug in my code.)
Also, you should use reader.readAsArrayBuffer;, which makes result an ArrayBuffer. The BrowserFS Buffer implementation has a zero-copy constructor that takes an array buffer (just use new Buffer(result)).
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
The error is Uncaught TypeError: undefined is not a function. It is thrown here, when the character extracted from the buffer is not a key in typeParserMap. So the result of the lookup is undefined and then I happily call it.
If you still think it's a problem BrowserFS should have detected. I'll give you any more information you need.
I will refactor my code to to accept a NodeBuffer, rather than a file system. Muchas gracias!
from ts-python-interpreter.
jvilk
commented on June 19, 2024
Oh, then it's likely not a code in my bug, just that you were doing the wrong thing w.r.t. writing the file in UTF-8 format, since pyc files are binary files. Meaning, you were:
- Reading a
pycfile using aFileReader. - Instructing the
FileReaderto interpret the file as a UTF-8 string, and return it as a JavaScript string (equivalent to you opening thepycfile in a text editor). - Instructing BFS to write the JavaScript string as a UTF-8 string.
Not all bytes are valid UTF-8 characters, so who knows what FileReader does when the file is invalid (it might just drop those bytes). So the written file on the BFS side in this procedure is unlikely to match the original file.
Reading the file as an array buffer correctly preserves the data.
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
That makes sense.
from ts-python-interpreter.
ppegusii
commented on June 19, 2024
Refactored to use NodeBuffer. All set.
from ts-python-interpreter.
Related Issues (20)
- Separate code into multiple files HOT 5
- Unit test parser
- Represent complex numbers HOT 3
- Check for bad marshal data when parsing
- do unit tests need to be specified to qunit as async b/c of callback?
- Create classes for all parsed types?
- typeLong in MarshalParser.ts may not be working
- How is __name__ loaded into the locals/globals/builtins
- CALL_FUNCTION with parameters
- Interpret pyc with conditionals and loops
- interpret pyc with arithmetic
- interpret pyc that uses imports
- interpret pyc that has classes
- Implement opcodes related to implemented types we've covered
- Compiling throws error on "
- Compiling throws error on require for node HOT 1
- which objects are in the tuples? HOT 1
- Implement parsing HOT 1
- Represent 64 bit integers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ts-python-interpreter.