Git Product home page Git Product logo

Comments (9)

navorite avatar navorite commented on September 17, 2024

This isn't a bug. Chromium browsers are designed this way; popups count as a window and that makes it the currently viewed window instead of the actual window in the browser. However, this doesn't occur in Firefox as Firefox doesn't consider extension popups as windows.

from sessionic.

inson1 avatar inson1 commented on September 17, 2024

@navorite ok, but that isnt something I want as user to deal with (not trying to be rude), I just want to look at the window I'm using. I dont care about the popup and I dont count it as window. Even if I did I only care about the "big window". - average user (I think xD)

ok, that is chromium design, but I think it shouldnt be also your design, if it can be fixed. That feature is everywhere only on one place is missing.

Can get that information after clickig on the icon, but before creating the window? Or just save viewed window id when I'm browsing (yes not ideal)?

Its also important for #71. But yes there are more important stuff.

from sessionic.

navorite avatar navorite commented on September 17, 2024

@navorite ok, but that isnt something I want as user to deal with (not trying to be rude), I just want to look at the window I'm using. I dont care about the popup and I dont count it as window. Even if I did I only care about the "big window". - average user (I think xD)

ok, that is chromium design, but I think it shouldnt be also your design, if it can be fixed. That feature is everywhere only on one place is missing.

Can get that information after clickig on the icon, but before creating the window? Or just save viewed window id when I'm browsing (yes not ideal)?

Its also important for #71. But yes there are more important stuff.

I think you are confused about what Chromium design means: Chrome provides some APIs for me to be able to differentiate whether this window is the active one or not, and Chrome simply designing the API this way makes you basically helpless.

Now there can be some workarounds - although I haven't tested them to make sure they work - such as what you mentioned earlier getting the active window when clicking on the icon, but this affects other things: Now every time you click the icon, the background script gets called, using more computer resources, which beats one of the main goals of the extension.

This highlighting feature is not really a critical one, I have only implemented it for convenience. I'd describe it as a progressive enhancement of the user experience.

I'll open it for now, but I won't be working on it at least in the meantime. If you can open a PR and implement the workaround in a way that doesn't have these limits I'd be more than happy to merge it.

I also recommend making the Full View mode enabled by default, it is the recommended way for using the extension.

from sessionic.

inson1 avatar inson1 commented on September 17, 2024

@navorite
Why it isnt the default?
Where do you recommend it? Maybe I miss something?

from sessionic.

navorite avatar navorite commented on September 17, 2024

@navorite Why it isnt the default? Where do you recommend it? Maybe I miss something?

Maybe I should change it to be so. I wanted the user to know that the Popup mode also exists. I'm not entirely sure, should I make Full View only enabled by default?

from sessionic.

inson1 avatar inson1 commented on September 17, 2024

@navorite
I think the recommended way should be the default.
But Why isnt popup the recommended way?

from sessionic.

inson1 avatar inson1 commented on September 17, 2024

@navorite Btw I fully got it first time :) Chromium has different design = its hard to implement - but it could maybe still work
I didnt say its critcal. Yes it isnt, but it would add to better UX.
I think on click could maybe work

from sessionic.

navorite avatar navorite commented on September 17, 2024

@navorite I think the recommended way should be the default. But Why isnt popup the recommended way?

I don't know how to describe it, I personally use the Popup for quickly doing stuff. If I'm on Full View it means I'm gonna do a lot of stuff with the sessions.

from sessionic.

inson1 avatar inson1 commented on September 17, 2024

@navorite I think that shouldnt be the reason for any of that two things tbh :) In most cases you want just do some easy thing right? Popup should be enough for that.

from sessionic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.