make the environment's deps explicit in the README about upf-bpf HOT 4 CLOSED

@RPierini Thanks to point this. Absolutely. I know that that are a lot of things to improve. I would love to see an PR with this change. Let me know if you need any help. Feel free to reach me on discord server.

from upf-bpf.

@RPierini Thanks to point this. Absolutely. I know that that are a lot of things to improve. I would love to see an PR with this change. Let me know if you need any help. Feel free to reach me on discord server.

Thanks! I'll do my best to try and solve this. I'll get in touch through Discord later too! As I said, i'm not used to github, and I started reading about the SSH and GPG keys management in GH and I think I got why you're sending those files to the container at build time. In the README it's said that the private key would be sent within the container, but maybe if the build was multi-stage like described here, then the key file would be in the intermediate build, but not inside the final image.
Other point is that it's hardcoded in the script to use a RSA key, but it seems that GH started to recommend ed25519 keys for key authentication. I'll try to modify the build_docker script for it to ask which key from the user's .ssh folder to use or to use a priority criteria (like ed25519 > dsa > rsa) to choose the key file to use.

I'll try to address those points in the PR, is that ok?

from upf-bpf.

@RPierini Thanks to point this. Absolutely. I know that that are a lot of things to improve. I would love to see an PR with this change. Let me know if you need any help. Feel free to reach me on discord server.
[...]
Other point is that it's hardcoded in the script to use a RSA key, but it seems that GH started to recommend ed25519 keys for key authentication. I'll try to modify the build_docker script for it to ask which key from the user's .ssh folder to use or to use a priority criteria (like ed25519 > dsa > rsa) to choose the key file to use.

Ok, about this part of my last comment, I just saw the "env.sh" file in the script and it's configurations... I'll address it in the PR for the README file for reference 😉

from upf-bpf.

PR #65 solved this issue

from upf-bpf.