Git Product home page Git Product logo

Comments (8)

jbweston avatar jbweston commented on August 22, 2024 2

I have investigated a little more deeply and have come to the following conclusions:

  1. This is not a platform-dependent bug
  2. This is a problem with pylibdmtx, not the upstream library

Evidence

This is not a platform independent bug

I have managed to replicate this problem on my machine (Debian testing) with the apt installed libdmtx (v0.7.5), as has @akhmerov.

This is a problem with pylibdmtx

I used the first part of @justinvdk's script above to generate a problematic datamatrix. I then saved this to a PNG file and read it in using the dmtxread program installed with apt, which is linked against libdmtx v0.7.5, and it produces the correct result.

What's the problem

I believe that the API to libdmtx has changed between 2 bugfix releases, when really there should have been a minor (or even major) version release.

I used the shell script from this gist with git bisect in the libdmtx repo to find that this commit is where things stopped working. I notice that this commit actually changed the API of libdmtx by adding extra fields to some of the exported datastructures. This means that the wrappers in wrapper.py are formally incorrect, and things break in unexpected ways.'

from pylibdmtx.

quicklizard99 avatar quicklizard99 commented on August 22, 2024 2

Included in v.0.1.8, now on PyPI.

from pylibdmtx.

kursancew avatar kursancew commented on August 22, 2024 1

from pylibdmtx.

bsdis avatar bsdis commented on August 22, 2024

Seems like this was not fixed after all... I am also getting these unexpected results on MAC

from pylibdmtx.

superted6851 avatar superted6851 commented on August 22, 2024

Downgrading to libdmtx to version 0.7.4 fixes the issue. Therefore I suggest the issue is with latest libdmtx and not pylibdmtx.

from pylibdmtx.

akhmerov avatar akhmerov commented on August 22, 2024

I now observe this issue with libdmtx 0.7.5 and Ubuntu 18.10.

from pylibdmtx.

jamespeterthornton avatar jamespeterthornton commented on August 22, 2024

Hi @quicklizard99 @kursancew, have you had a chance to look at this? This seems to be a breaking issue on fresh installs of this repo. @jbweston's fix resolves it on my machine. His PR is ready to be merged, but additional information is needed on how to update CI to run with the newest version of libdmtx.

(Although, some broader changes may be required if backwards compatibility with libdmtx is viewed as a necessity. Depending on scope, I can potentially help out as well in order to get this repo working again.)

from pylibdmtx.

jamespeterthornton avatar jamespeterthornton commented on August 22, 2024

Awesome, thank you!

from pylibdmtx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.