poppler >= 21.12 require c++17 about openfx-arena HOT 6 OPEN

https://gitlab.freedesktop.org/poppler/poppler/-/commit/5bebbe59a1e971dfd6b2f1f76d51dc544239ffb6
https://en.cppreference.com/w/cpp/string/basic_string_view (since C++17)

This is an issue with poppler IMHO.

from openfx-arena.

I can confirm openfx-arena builds with poppler 22.08.0 when -std=c++17 is used.

Can't we simply bump the C++ standard version used?

from openfx-arena.

Use CMake? -DCMAKE_CXX_STANDARD=17.

from openfx-arena.

I did something similar and yep, it works for me. I am just suggesting to change the default in Makefile.master, so that others don't face the same issue

from openfx-arena.

poppler includes should at least disable declarations of C++17-specific API, which we don't use in ReadPDF anyway. But we have to deal with how the poppler developpers enforced compiling in C++17 mode.

There should be no issue with compiling in C++17 mode on clang, GCC, and VC++, according to this: https://stackoverflow.com/q/46746878

C++17 is necessary only to compiler ReadPDF with poppler >= 21.12, but I think it's OK to enable it to compile the whole plugin set. I wouldn't switch the main Natron code to using C++17, since it's still being built with Qt4, which barely supports C++11.

BTW, this line in openfx-arena:

globalParams.reset(new GlobalParams(popplerData.c_str()));

should be replaced by

globalParams = make_unique<GlobalParams>(popplerData.c_str()));

from openfx-arena.

Ok, will bump to c++17. I'm busy today, but will do it tomorrow (also got other fixes for openfx-arena in my queue).

I wouldn't switch the main Natron code to using C++17, since it's still being built with Qt4, which barely supports C++11.

On Windows using latest GCC (12) and MinGW I'm not able to build Qt4 with c++11 anymore, had to revert to c++98 (just gets random failures with c++11 and beyond).

from openfx-arena.