PDFKit RangeError: Maximum call stack size exceeded about fluentreports HOT 3 CLOSED

Awesome, thanks for the confirmation. I'll upload a new version of the code as that monkey patching should actually have been safeguarded to make sure people can't accidentally do what you did. Thanks for the report and it is now fixed in v1.4.1

from fluentreports.

Your issue is very weird. There are two possibilities I can think of (the second being more likely)...

And yes, you are correct this code just eliminates basically empty stuff, however I think w/o the _finalize code you might randomly get output glitches occasionally as null offsets would probably be translated to 0,0 offsets...

1. Can you tell me which version of PDFKit that you are using, maybe an upstream change in it broke something...

2. The main thing I can think of is that somehow the FluentReports.pdfkit.js overrides is being initialized multiple times and replacing _end & _finalize a second time in the PDFKit, which would for sure create a loop like you are seeing.
   Could you be using two different copies of FluentReports or perhaps FR is npm installed in two (or more) directories, or perhaps their is some weird issue with bundling or node that is causing the fluentreports.pdfkit.js to be loaded a second time. In any case, changing the code in all copies of fluentreports/lib/fluentReports.pdfkit.js to the following should eliminate that possibility...

if (!pdfkit.prototype._PKIEnd) {
 pdfkit.prototype._PKIEnd = pdfkit.prototype.end;

  pdfkit.prototype.end = function () {
     if (this.isEmptyPage()) {
         this.deletePage();
     }
     this._PKIEnd();
 };
}

if (!pdfkit.prototype._PKIFinalize) {
 pdfkit.prototype._PKIFinalize = pdfkit.prototype._finalize;
 pdfkit.prototype._finalize = function (fn) {
     let i = 0;
     while (i < this._offsets.length) {
         // Eliminate any NULL Offsets from deleted pages
         if (this._offsets[i] === null) {
             this._offsets.splice(i, 1);
             continue;
         }
         i++;/
     }
     this._PKIFinalize(fn);
 };
}

from fluentreports.

Thanks for the quick response. That code snippet worked!

It also prompted me to test a bit more to see if I could optimize how those routes are loading.

I found that using
const Report = require('fluentReports').Report;
at the top of my report generation files caused the overrides to be initialized in each file (then would later cause the stack overflow).

then replacing
const Report = require('fluentReports').Report;
with
import { Report } from 'fluentReports';
fixed the issue without your code changes.

FluentReports was up to date and using pdfkit .13 - for reference I also tried previous versions of fluentreports that used pdfkit .12 and .11 but had the same issue. Also pdfkit isn't installed anywhere else in our lock file so no conflicts there.

Either way that helped solve things, and eased my mind a bit 😄 thanks again!

from fluentreports.