Registry not working properly about jayschema HOT 7 CLOSED

@pvorb I can’t duplicate this problem. First, are you sure the $ref is correct?

In the sample above the host name is [a real host name] but you mentioned that the schema hostname was example.org. Maybe you just forgot to obscure the hostname in the sample code above? Or maybe it’s wrong in the schema.

Here’s the test code I used, and it worked:

var JaySchema = require('jayschema')
  ;

var addressSchema = {
  "id": "https://example.org/api/address.schema.json",
  "type": "string"
};

var masterSchema = {
  "title": "user",
  "id": "https://example.org/api/user.schema.json",
  "properties": {
    "addresses": {
      "type": "array",
      "items": {
        "$ref": "https://example.org/api/address.schema.json"
      }
    }
  }
};

var data = {
  "addresses": [
    "address1",
    "address2",
    "address3"
  ]
};

var js = new JaySchema();
console.log(js.register(addressSchema));      // prints []
console.log(js.validate(data, masterSchema)); // prints []

from jayschema.

Paul,

I’ve found that the getMissingSchemas() method was incorrectly reporting some schemas as missing. Still, validation would have been successful. This wasn’t exactly the problem you reported, but maybe it was related. That bug has been fixed as of 0.1.3.

Regards,
Nate

from jayschema.

Thank you. It doesn't solve my problem, so there must still be some problem hidden in my implementation. I'll have a in-depth look on it.

Maybe you just forgot to obscure the hostname in the sample code above?

Exactly. :-) I updated the question. Can you please replace the domain in the answer above, since it shouldn't become public yet?

from jayschema.

It works with version 0.1.3 when I'm using getMissingSchemas() instead of the result of js.register(schema). Maybe you should test the following:

var js = new JaySchema();
console.log(js.register(addressSchema));      // prints []
console.log(js.register(masterSchema));       // prints [ 'https://example.org/api/address.schema.json' ]
console.log(js.validate(data, masterSchema)); // prints []

I think the second log should print [] too.

from jayschema.

Sorry about that. It’s fixed in 0.1.4.

I went through the registry code and centralized the logic when checking for missing schemas, and made sure all checks use normalized ids. Added tests for this.

from jayschema.

Great, thanks. BTW: This may be interesting for you.

from jayschema.

Thanks for the pointer. Personally I thought validate(schema, data) made more sense, but I specifically chose validate(data, schema) to be compatible with other validators. Hopefully that will be helpful to you and others.

from jayschema.