Comments (2)
cFE/modules/es/fsw/src/cfe_es_apps.c
Lines 606 to 607 in 0316672
from cfe.
This is common with static analysis, in that it doesn't know context or relationships between things. Specifically in this context the CFE ES task ID is a conversion from the OSAL task ID, and its in a context where the OSAL task ID was checked. Here's a bit more context:
cFE/modules/es/fsw/src/cfe_es_apps.c
Lines 598 to 607 in 0316672
Although CFE_ES_LocateTaskRecordByID()
can theoretically return NULL, it only does so if/when passed in an ID that's not within the valid range. But unless the CFE_ES_TaskId_FromOSAL()
is broken, the ID that this returns cannot be out of range.
This is a bit of a design holdover from the days where the OSAL ID was directly used as the CFE task ID. Its no longer used directly, but there is a 1:1 mapping between them, and that mapping is implemented in the CFE_ES_TaskId_FromOSAL
function. So as long as that mapping is OK and for every valid OSAL ID it returns a valid CFE ES task ID, there is no real danger here.
That's not to say its 100% robust - changing OSAL or CFE could break this - but in the current configuration it is not possible to get a NULL return fromCFE_ES_LocateTaskRecordByID()
here. I am not sure, but its possible that it was checked for NULL at one point but was impossible to reach from coverage testing, thus removed.
from cfe.
Related Issues (20)
- EVS event messages - add (optional!) stack traces
- CFE_MSG_Message_t should really be a struct, not a union HOT 2
- CFE_ES_CreateChildTask ignores its StackPtr argument
- Add runtime TopicID -> MsgID conversions
- Add encode/decode hooks for TBL services load/dump routines
- EVS_GenerateEventTelemetry has a race condition HOT 2
- TBL main task blocked for duration of CFE_TBL_DumpToFile call
- Possible PortMessage buffer truncation HOT 2
- Correct SendHk command naming mismatches
- TBL: consolidate repeated logic blocks
- Switch rtems workflows to generic-rtems
- Improper stack object access in the msg api functional test
- Introduce transaction object for CFE TBL
- Improve application developer guide documentation
- Use consistent time definition for TBL subsystem data structures
- Remove conditionally-compiled code in TBL
- Add "foreach" function for access descriptor looping
- Use proper resource identifers for table validation and dump state structs
- Static analysis issues JSC 2.1
- address sanitizer option detect segv in es_UT.c
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cfe.