[Enhancement]: Live Rover Pose Improvements about mmgis HOT 12 CLOSED

Yes, that reset button was never meant for the composite layers too (though I suppose it could be).

I'll look into the flickering more.

from mmgis.

Thanks! I should've caught that one. I'm going to merge this all now too.

from mmgis.

hi Tariq, I'm noticing the following:

• keepLastN immediately following an updateVectorLayer no longer works. I've switched to the pattern where the keepLastN value is passed to the updateVectorLayer call instead, and that works.
• Uncertainty Ellipse state is reset on every layer update (new feature added)
• Opacity state is reset on every layer update (new feature added)

This video is using the ts-485 branch:
https://github.com/NASA-AMMOS/MMGIS/assets/2343076/519ca5aa-a932-46c0-bfa9-0c230647d291

from mmgis.

Separate, but I'm also seeing this error:

It looks like this is the code, and for some reason it's accessing that layer at a string of "0" instead of an index of 0? I've attempted to capture what I'm seeing in this image:

from mmgis.

Also unrelated (and I can move this elsewhere), sometimes I'm having issues moving drawing features (unsure if related to the error in the previous comment). See the following video using the ts-485 branch:
https://github.com/NASA-AMMOS/MMGIS/assets/2343076/9bdb9758-a7ca-43e1-abd6-95fa47a0652a

from mmgis.

@khalidadil Thank you for investigating further issues; I'll starting working on them right now.

As for dragging drawn features, that functionality was in an adjacent PR and now in the development branch -- this ts-485 does not have that addition.

from mmgis.

keepLastN immediately following an updateVectorLayer no longer works. I've switched to the pattern where the keepLastN value is passed to the updateVectorLayer call instead, and that works.

Yes, keepLastN internally calls an update/make layer function that can sometimes race/conflict with updatevectorlayer. The new pattern is preferred now and should be a little more performant.

from mmgis.

@khalidadil I've addressed the remaining issues too -- please give it another try. Thanks!

from mmgis.

@tariqksoliman Still testing this, but noticing we're still getting flickering of the rover image. I'm not sure what can be done about this:
https://github.com/NASA-AMMOS/MMGIS/assets/2343076/7c30e4d3-3e8b-4985-8e25-1e846117a9e7

from mmgis.

I'm also noticing that clicking the reset icon next to the "Layer Settings" text only resets the Opacity, not the "Composite Layers" settings. Is that the intended behavior?

from mmgis.

@khalidadil Just pushed another change to address the flickering. Could you give it try again? Thanks!

from mmgis.

@tariqksoliman This is looking great now! I can confirm the 3 layer settings for vector opacity, image overlay opacity, and ellipse toggle work as expected, and I'm not seeing flickering when the rover changes positions on the map. I need to bring this into an environment where I can test the memory issue again, but otherwise things are looking really good!

When clicking on the rover or the historical track features, I am seeing this error:

I think the error is happening here in Map_.js:

There was another error, but it was potentially unrelated. I'll see if I can figure out how to cause it to happen again.

from mmgis.