The client cannot work in a multi-threaded environment about gitlab HOT 11 CLOSED

Here is an example how to work with multiple servers:

client1 = Gitlab.client(endpoint: 'https://api1.example.com', private_token: '001')
client2 = Gitlab.client(endpoint: 'https://api2.example.com', private_token: '002')

from gitlab.

Nope. I tried that. It fails. client1 will try getting paths using client2's host. It's because the code uses httparty in an un-thread-safe way.

An obvious example is setting the base_uri on the Gitlab::Client class instead of an instance in users.rb:13 but I'm sure there are other problems.

from gitlab.

Is it also affects private_token? Does it also stored in class variable?

from gitlab.

No class variables were used.

from gitlab.

@NARKOZ thanks. So its only base_uri is global now right?

from gitlab.

@randx commit bf4512f was reverted, so currently it isn't.

from gitlab.

@NARKOZ thank you

from gitlab.

@NARKOZ any chance you will release new version of gem with fixes soon?

from gitlab.

New version will be released in a couple of days.

from gitlab.

@NARKOZ thanks! ❤️

from gitlab.

Can we close this issue now?

from gitlab.