Git Product home page Git Product logo

Comments (4)

nao1215 avatar nao1215 commented on July 16, 2024 1

@phanirithvij
Thank you for your comment.
gup does not support ldflags; an implementation is needed to support ldflags.

from gup.

nao1215 avatar nao1215 commented on July 16, 2024

NOTE: need to change this code.

gup/internal/goutil/goutil.go

Lines 189 to 204 in ce661c5

// Install execute "$ go install <importPath>@latest"
func Install(importPath string) error {
if importPath == "command-line-arguments" {
return errors.New("is devel-binary copied from local environment")
}
var stderr bytes.Buffer
cmd := exec.Command(goExe, "install", importPath+"@latest")
cmd.Stderr = &stderr
err := cmd.Run()
if err != nil {
return fmt.Errorf("can't install %s:\n%s", importPath, stderr.String())
}
return nil
}

from gup.

phanirithvij avatar phanirithvij commented on July 16, 2024

Found a way to do it with environment vars

# for a reproducible build
GOFLAGS="-buildmode=pie -trimpath -mod=readonly -modcacherw -ldflags=-s" gup update
# or just
GOFLAGS="-ldflags=-s" gup update

from gup.

phanirithvij avatar phanirithvij commented on July 16, 2024
  • As for whether or not gup should have ldflags, I think it would be helpful, when complex ldflags like for e.g. -X pkg/path.VersionX ... -X ... are needed. But for simple things like above GOFLAGS should suffice.
  • and I don't think people using gup update are expecting any such wild behavior other than just cli binaries getting updated.

from gup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.