Comments (9)
@dalisoft b0e7e4b solved it for body-parser. Nice!
from middlewares.
@torbjorn-kvist Please test it on both ESM and CJS mode and let me know results
from middlewares.
it seems that it can be fixed by doing this:
torbjorn-kvist@db7fd3c
Not sure how to test it without publishing an npm package, tried to do a .tgz with npm pack but was not allowed to installed. But tried to do the same changes in node_modules
.
When doing these changes it works, also need to the same change in https://github.com/dalisoft/npm-packages/tree/master/packages/getdirname because schemator
is using it.
It works if you import the packages as '@nanoexpress/middleware-schemator/module' but then I'm getting the same error for getdirname
.
Not sure how you want to solve this, but it seems to work with the current changes on the fork.
from middlewares.
@torbjorn-kvist Can you make PR for this? If possible with tests please, i'll fix this as soon as i can, but seems it's not current month, at next month i think i can do. If you need faster result, please submit PR
from middlewares.
Can make a PR for it, but not sure how to test without another repository importing it from package.json. Will try to look into both when I get some time over.
from middlewares.
@dalisoft I was able to test body-parser on both ESM and CJS and can confirm both modes are working!
from middlewares.
Thanks @cryptodeal
I also tested body-parser and it works, but i am stuck with schemator plugin solution for getdirname dependency.
from middlewares.
Only schemator
has bug with CJS as it's has dependency called getdirname
, once i'll fix that dependency, schemator
also will be able use full-compatible Node.js power
from middlewares.
Commit 0ca4a3e fixes this issue completely (or should fix at least)
from middlewares.
Related Issues (15)
- "staticServe" sending wrong file issue HOT 9
- file-upload middleware HOT 3
- Static serve middleware is not working HOT 3
- @nanoexpress/middleware-file-upload not found on NPM HOT 2
- module not found formidable middleware HOT 6
- @nanoexpress/middleware-schemator esModule import on cjs HOT 11
- @nanoexpress/middleware-schemator Possibility to add title to initialize options HOT 2
- @nanoexpress/middleware-schemator error serve swagger
- @nanoexpress/middleware-static not give an response if file not found HOT 1
- Any other middleware in the todo list
- CJS version - End-of-Life HOT 1
- Expressjs-Session returns error HOT 1
- Body parser not working HOT 1
- [Security Bug]: CVE GHSA-ff7x-qrg7-qggm HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from middlewares.