Git Product home page Git Product logo

Comments (8)

kyrielia avatar kyrielia commented on May 28, 2024 4

I think that @petschki's comment in #199 is valid. I.e. this action should allow you to specify that would like to use Chrome's latest stable build. This could avoid similar problems in future.

This is a feature in https://github.com/browser-actions/setup-chrome, for example.

It's worth noting that the latest stable build (115.0.5790.170) currently appears in the good versions matrix:
https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json

from setup-chromedriver.

ahukkanen avatar ahukkanen commented on May 28, 2024 3

We are currently experiencing the same issue.

Just throwing this as an idea here as I may not know all the consequences of my suggestion, but how about fetching the latest point release of the same Chrome version in case the URL is empty at this point (as in this particular error):

echo "Downloading $URL"

I mean before that line, checking the $URL variable if it is empty and then fetching the latest point release as a fallback mechanism like:

curl  --location --fail --retry 10 https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json | jq -r ".versions[] | select(.version | startswith(\"$(echo $VERSION | cut -d '.' -f1-3).\")) | .version" | tail -1

E.g. for the problematic version 115.0.5790.110, this would fetch all the releases starting with 115.0.5790.. This would return the following list of versions:

115.0.5790.3
115.0.5790.13
115.0.5790.24
115.0.5790.56
115.0.5790.75
115.0.5790.90
115.0.5790.98
115.0.5790.102
115.0.5790.170

And picking the last one with the tail -1 pipe would result to setting the version number to 115.0.5790.170.

Do you see some issue with this approach as a fallback mechanism? I understand that the legacy http://chromedriver.storage.googleapis.com/LATEST_RELEASE_114 URL is doing something similar and that could also result into version conflicts between Chromedriver and Chrome. I would imagine that by discarding only the last part of the version number would not result to any major incompatibilities.

from setup-chromedriver.

nanasess avatar nanasess commented on May 28, 2024 3

Thank you all for your contributions!, Fixed version has been released.
https://github.com/nanasess/setup-chromedriver/releases/tag/v2.1.2
I adopted the curl command suggested by @ahukkanen, Thank you so much!

from setup-chromedriver.

aeros281 avatar aeros281 commented on May 28, 2024 1

Wouldn't locking chrome-driver cause mismatch between chrome & chromedriver because the action install the latest chrome?

from setup-chromedriver.

mingyaulee avatar mingyaulee commented on May 28, 2024 1

I am currently having this problem but running in windows-latest. Can the fix commit be adopted in the ps1 to ensure cross platform consistency?

Edit: I have created the PR for this here

from setup-chromedriver.

nanasess avatar nanasess commented on May 28, 2024

@dnys1 115.0.5790.110 seems to have failed to build.
Please check the following:
#199 (comment)

from setup-chromedriver.

nanasess avatar nanasess commented on May 28, 2024

@ahukkanen
Thank you for your suggestion.🙏
In addition to setup-chromedriver.sh, there is also setup-chromedriver.ps1 support.
We don't want to complicate the shell script or PowerShell any further.
I would prefer #159.

Of course, we welcome pull requests for your suggestions!

from setup-chromedriver.

kyrielia avatar kyrielia commented on May 28, 2024

Also seeing this.

Latest version of chrome being picked up by setup-chromedriver: 115.0.5790.110
However latest stable of chrome is: 115.0.5790.170

from setup-chromedriver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.