Comments (5)
This is a pretty serious bug.
from httpclient.
Yes, it's an API change. Timeout::Error (::TimeoutError) should be handled by the code who called Timeout.timeout.
I don't know how we treat this kind of nested timeout...
from httpclient.
There is nothing for httpclient to do except throw a subclass of ::TimeoutError. It doesn't need to know anything about the outer timeout. As stated the proposed change restores old semantics and still allows new code to distinguish between ::TimeoutError and HTTPClient::TimeoutErrors.
Want a unit test to illustrate the issue and the fix?
from httpclient.
I don't want to throw non StandardError from a library. In 1.8, it's not a StandardError.
0% ruby187 -rtimeout -e 'p Timeout::Error.ancestors' [Timeout::Error, Interrupt, SignalException, Exception, Object, Kernel] 0% ruby -rtimeout -e 'p Timeout::Error.ancestors' [Timeout::Error, RuntimeError, StandardError, Exception, Object, Kernel, BasicObject]
So as a CRuby committer hat, I want to find the way to handle this kind of nested timeout.
As a workaround, can you use httpclient's timeout instead of outer one? (I don't think so...)
from httpclient.
I close this issue as "Wont' fix" because it's a "BUG" that introduced incompatible change to API as original reporter stated. But I still am thinking that it's required change (::Timeout::Error == ::TimeoutError must be handled only by timeout library, not by others) so I cannot revert the change (I cannot change ReceiveTimeout, etc. to a subclass of ::TimeoutError.)
Since this API incompatible BUG lasted over 3 years I assume this change was accepted.
from httpclient.
Related Issues (20)
- Method invocation may produce 'NoMethodError'
- HTTPClient::KeepAliveDisconnected: HTTPClient::KeepAliveDisconnected: Broken pipe HOT 1
- How to handle content with encoding UTF-16 with BOM present?
- Cookies with a SameSite attribute cause a warning to be output HOT 2
- Why HTTP::Status do not have 404 status code (not found)?
- Support connection to proxy via https scheme HOT 3
- Make a new release? HOT 3
- HTTPClient.create_request should not set content type for empty bodies
- warning: method redefined / assigned but unused variable
- [Chore] Documentation unavailable
- Timeout::timeout inherently unsafe, switch to socket nonblocking io
- Query on httpclient default gem default certificates
- Delete httpclient default gem default certificates
- Time for a release, maybe? HOT 6
- Issue parsing Digest challenge
- Connection to Lets Encrypt secured server fails HOT 14
- Test failures with webrick 1.7 HOT 3
- Cookies are added as multiple headers, which is invalid
- Is there any CI?
- support OpenSSL::SSL::SSLContext#add_certificate
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpclient.