[FEAT] Ensure consistency between all methods to define application commands about naff HOT 2 CLOSED

So - taking this issue literally, i disagree with the premise All methods to define application commands should have consistent signatures - same args, same type hinting, same defaults

if we look at the methods to instantiate a app command we have

• @slash_command
• @subcommand
• class SlashCommand
• SlashCommand.subcommand

Going one by one;

• @slash_command being the recommended to make a non-sub app command. Its type hints are weird, they should be fixed.
• @sub_command as per its docstring, is inteded to be an alternate way to define a slash command, specifically for sub commands. It was also requested. By its very purpose it should NOT have the same signature as @slash_command
• SlashCommand.subcommand is the alternate to @sub_command- which creates a subcommand from an existing command, as it is creating a command based off of another, there are certain fields it should not have. Again meaning it shouldnt share a signature
• class SlashCommand being the last suppported way to create a command, isnt really an recommended way to define commands, its designed to act as a model, not a construction vector. By its very purpose, it shouldnt mirror the type hints nor signature of the decors as its use case would be completely different.

I'll admit work could be done to ensure the resultant command object has the same defaults between them, but a blanket all signatures should be the same is asinine and defeats the purpose of having multiple methods. They are literally not supposed to be the same

If ive missunderstood, please correct me.

from naff.

Closing due to inactivity

from naff.