[FEAT] Allow Multiple Bot Instances In The Same Process about naff HOT 8 CLOSED

@silasary

Reading the code, I'm not convinced this is accurate.

My theory to the cause was based on the wrapping process. The library literally wraps objects and uses the current client as a param. Figuratively owning the object.

I believe there are other issues resulting in the behaviour I've found, but I've yet to have time to debug further so I reported what I had found so far.

End of the day the lib wasn't written with multi-instancing in mind, so a few changes are required. Shouldn't be too bad, just annoying

But either way we spin it, more testing is needed to determine the cause of the behaviour. As I'll admit, I'm theorising

from naff.

Currently waiting on #346 before more progress can be made here

from naff.

Is there any prio status on this, or labeling? I'm currently having issues making this work as well, there's only one main heartbeater and other instantiations of the client fail to create others respectively. Adding a __new__ magic for this would be very convenient with IPC-based solutions.

from naff.

So, it can be done without to much pain, the downside is there isnt a public method to make it work. Please excuse the ugly test code

tokens = [...]
bots = []

for token in tokens:
    _bot = Snake()
    bots.append(_bot)
    print(f"Logging in with {token}")
    loop.run_until_complete(_bot.login(token))
    print(_bot.user.username)


print(f"Attempting to start {len(bots)} gateways")
loop.run_until_complete(asyncio.gather(*[b.start_gateway() for b in bots]))

This will create n number of bots and connect them all, however the issue arrises that the bot instances attempt to own listeners, meaning one bot will get all events. In real terms this means if you run a command, one bot will respond twice, meanwhile the other bot wont do anything, this is fixable, but not ideal.

from naff.

could this be sorta monkey-patched by not using @listen() decorators and manually registering them?

from naff.

bot instances attempt to own listeners, meaning one bot will get all events.

Reading the code, I'm not convinced this is accurate.

by not using @listen() decorators and manually registering them?

You'd need to convert them into listeners to register them anyway.

from naff.

Any movement on this?

from naff.

We are now working on this... it is suffering incarnate

from naff.