Git Product home page Git Product logo

Comments (6)

artem30801 avatar artem30801 commented on August 17, 2024

Can checks user code raise an error? If so, both check name (or check object entirely?) and user-raised exception could be stored in CommandCheckFailure attributes

from naff.

LordOfPolls avatar LordOfPolls commented on August 17, 2024

That's fine by me

from naff.

LordOfPolls avatar LordOfPolls commented on August 17, 2024

Im unsure on what structure this data should be communicated. Just a string with the check's method name?

from naff.

AstreaTSS avatar AstreaTSS commented on August 17, 2024

Is it possible to send the whole function? Who knows, maybe someone will have two checks named the same thing.

If not, the name would be the best way to do it.

from naff.

LordOfPolls avatar LordOfPolls commented on August 17, 2024

it apparently already was, and according to git-blame it has been there since the CommandCheckFailure class was created
image

from naff.

LordOfPolls avatar LordOfPolls commented on August 17, 2024

Closing this issue as per the above

from naff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.