Add optional color setting for axis about line-chart HOT 7 CLOSED

Sure thing, man ! Please please please before you send your PR make sure you have tested what you added :-)

Thanks !

from line-chart.

All right, I've hacked a little bit this bug and it appears that you should add a CSS rule to style the chart instead of enforcing style declaration within the charting library.

For instance, you can do the following :

.my-awesome-chart .axis text {
  fill: blue;
}

.my-awesome-chart .axis path {
  stroke: blue!important;
}

Note : the !importantis here because the path elements do have a color, otherwise they would be invisible if not set. This is not the case for the text elements.

Other note : I don't recommend coloring anything in pure blue, for epilepsy's sake.

from line-chart.

Awesome. You beat me to the punch :D

Love the use of CSS instead of defining it in the options.

from line-chart.

You're welcome ! :-)

Just out of curiosity, what do you use line-chart for ?

from line-chart.

Well at the moment i'm not exactly using line-chart, but a very close version of it, lol. I needed to make some changes for the previous 3 issues i had created so i forked the code a little bit. But the reason i made the issues was because i'm hoping to go back to using your version. Soon 😄

Usage: I've recently been adding a reporting suite to the product that my company is working on. And well, tables are boring. We decided to use d3 as our main reporting engine, and after doing some research on various pre-made graphing systems, i decided that i wanted to use line-chart (and soon you're other pie-chart).

I do however have a few random questions, and would love to help the project out as much as I can. So if you don't mind, shoot me an email at gamegenius86 @ gmail. I'd love to pick your brain on a few things and see how if there is anything i can do to assist in this project going forward.

from line-chart.

+1. Would be great if the options object could have one more settings called axisColor that would set the color of the axis and its text. Currently we are doing it by CSS but it's more of a dirty hack. Our site has a dark theme and we can't use the default black color for axis.

from line-chart.

Yes, Obliviously

from line-chart.