Comments (7)
Sure thing, man ! Please please please before you send your PR make sure you have tested what you added :-)
Thanks !
from line-chart.
All right, I've hacked a little bit this bug and it appears that you should add a CSS rule to style the chart instead of enforcing style declaration within the charting library.
For instance, you can do the following :
.my-awesome-chart .axis text {
fill: blue;
}
.my-awesome-chart .axis path {
stroke: blue!important;
}
Note : the
!important
is here because the path elements do have a color, otherwise they would be invisible if not set. This is not the case for the text elements.Other note : I don't recommend coloring anything in pure blue, for epilepsy's sake.
from line-chart.
Awesome. You beat me to the punch :D
Love the use of CSS instead of defining it in the options.
from line-chart.
You're welcome ! :-)
Just out of curiosity, what do you use line-chart for ?
from line-chart.
Well at the moment i'm not exactly using line-chart, but a very close version of it, lol. I needed to make some changes for the previous 3 issues i had created so i forked the code a little bit. But the reason i made the issues was because i'm hoping to go back to using your version. Soon 😄
Usage: I've recently been adding a reporting suite to the product that my company is working on. And well, tables are boring. We decided to use d3 as our main reporting engine, and after doing some research on various pre-made graphing systems, i decided that i wanted to use line-chart (and soon you're other pie-chart).
I do however have a few random questions, and would love to help the project out as much as I can. So if you don't mind, shoot me an email at gamegenius86 @ gmail. I'd love to pick your brain on a few things and see how if there is anything i can do to assist in this project going forward.
from line-chart.
+1. Would be great if the options object could have one more settings called axisColor
that would set the color of the axis and its text. Currently we are doing it by CSS but it's more of a dirty hack. Our site has a dark theme and we can't use the default black color for axis.
from line-chart.
Yes, Obliviously
from line-chart.
Related Issues (20)
- Fix Typings HOT 2
- Dot Chart Issues HOT 14
- Is there a way to hide the legend? HOT 5
- Release Supported version for mobile app
- Set the dotsize
- Feature request: truncated x axis HOT 1
- [Question]If I want to update the chart data, based on the timeline, what should I do? HOT 1
- Pan and zoom should be persistent HOT 3
- "Google Chrome ran out of memory while trying to display this webpage" while continuously plotting. HOT 9
- Angular 2 Support HOT 3
- More data for Tooltips HOT 3
- vline symbols not showing on chart HOT 1
- Dot / column color with V2
- Dot Appearance & Shape
- Trendline
- No wheel support for zoom in v2 ?
- Internationalization of date
- Dynamic changed data grow up height of chart HOT 1
- mousemove event
- Easy - Website css issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from line-chart.