Strange output for toString method while using preact-i18n about preact-render-spy HOT 6 CLOSED

I noticed that preact-i18n doesn't have display names for it's components either... so added synacor/preact-i18n#4

from preact-render-spy.

That text nodes fix is published in 1.0.0-rc.8

from preact-render-spy.

Hrm... Can you maybe setup a reduced test case repo for me to start debugging from here? I'll have some time to dig in deeper later today, but it would be nice to not have to set up this scenario myself 😄

I have some thoughts about why... does preact-i18n use context/providers?

Also, was this with render spy's shallow or deep? I bet you it looks more like what you want on shallow

Can you try with import toString from 'preact-render-to-string/jsx' and toString(jsx, { shallow: true }) (we use the shallow option from render-to-string on our toString output)

from preact-render-spy.

aha, I found the specific issue! basically i assumed any truthy output from components was vnodes, but it can also be a string - which was then made into an invalid vnode

from preact-render-spy.

Sorry didn't had time to create a test repo! Glad you already found the problem :), thanks for the fast fix!

from preact-render-spy.

Also, just as a suggestion - you might want to just start using shallow as your default for testing (unless you're really depending on children components to do something) .

Let me know for sure that this patch fixed your string node issue tho :) (I'm pretty confident it did)

from preact-render-spy.