Webpack breaks on cached run about hard-source-webpack-plugin HOT 6 CLOSED

Hey @wmertens. I'm guessing you are doing something out of order. Are you using something imported before its imported? We had another bug like this related to exporting things before they were imported.

Do you have anything like

doSomething();
// ...
import {doSomething} from './some-file';

Just want to confirm so my regression test to go along with the fix keeps this from popping up again later.

from hard-source-webpack-plugin.

from hard-source-webpack-plugin.

I added a console.log(this) and this error happens for this this:

HardHarmonyImportSpecifierDependency {
  module: null,
  importDependency: undefined,
  importedVar: null,
  id: 'default',
  name: 'Promise',
  range: null,
  loc: 
   { start: { line: 5, column: 102 },
     end: { line: 5, column: 109 } } }

I changed it to log for this.name === 'Promise' and it turns out that the first run, it has Bluebird for Promise, and the second time, it shows the above output. So maybe something is using Promise before I polyfill it with Bluebird?

from hard-source-webpack-plugin.

All I needed to do was rename my bluebird import from Promise to something else and it stopped happening. Weird, because I never assigned to the Promise global, it seems that global name clashes are not appreciated?

from hard-source-webpack-plugin.

Oh wow. I think the Promise detail is exactly the issue. The good news is my 0.3.5 change in #80 works for this too. I'm guessing its a detail of the acorn parser webpack uses hoisting global names or some other similar mechanism effectively causing the specifier to appear before the import in the dependencies of that module.

I'm not worried about System.import being the cause. Its basically a fancy require.ensure dependency that doesn't have to deal with the more complex situations harmony imports and exports deal with.

Thanks for helping me figure this out @wmertens!

from hard-source-webpack-plugin.

🎉 can confirm it is fixed now!

Imports are hairy - I'm battling an issue where a Babel preset appears as an empty object unless I force-import it with node -r lib/myBabelPreset :-/

from hard-source-webpack-plugin.