Documentation mismatch for parsing strings in latest version about delorean HOT 6 CLOSED

I wont have time to look at this till monday, but I will fix it soon.

from delorean.

On the changelog for the python-dateutil==2.5.2 they say they fixed a bug regarding dayfirst and yearfirst.
https://github.com/dateutil/dateutil/blob/master/NEWS

dateutil/dateutil@2d42e04

Looking forward to know more about this.

from delorean.

I got an error of "ValueError: month must be in 1..12" from dateutil

File "/usr/local/lib/python2.7/site-packages/pynamodb/models.py", line 394, in refresh
self._deserialize(item_data)
File "/usr/local/lib/python2.7/site-packages/pynamodb/models.py", line 1142, in _deserialize
setattr(self, name, attr_instance.deserialize(value))
File "/usr/local/lib/python2.7/site-packages/pynamodb/attributes.py", line 260, in deserialize
print parse(value).datetime
File "/usr/local/lib/python2.7/site-packages/delorean/interface.py", line 68, in parse
dt = capture(datetime_str, dayfirst=dayfirst, yearfirst=yearfirst)
File "/usr/local/lib/python2.7/site-packages/dateutil/parser.py", line 1170, in parse
return DEFAULTPARSER.parse(timestr, **kwargs)
File "/usr/local/lib/python2.7/site-packages/dateutil/parser.py", line 580, in parse
ret = default.replace(**repl)
ValueError: month must be in 1..12
and repl = {u'hour': 22, u'month': 28, u'second': 20, u'microsecond': 600703, u'year': 2016, u'day': 3, u'minute': 38}

from delorean.

+1 on this

from delorean.

A quick fix for this to prevent breaks would be to set dayfirst's default value to False, also it is strange that they don't deal with yearfirst flag at all and ideally it should take priority since it was the default

from delorean.

Closing this as a duplicate of #87.

from delorean.