Comments (7)
I initially made this the default behaviour in order to help people from making mistakes with passing in localized datetime objects forcing them to take into account what they were actually doing.
I can see how this can be annoying for currently existing systems. I will definitely try to get this in an upcoming release.
Are there any other examples of usage? That are inconvenient to use it with that I may have missed?
from delorean.
I have a lot of code that also uses pytz for setting the tzinfo, so another nice feature would be to have the constructor accept as a single argument a datetime that has a pytz timezone:
e.g.
dt = datetime(2010, 3, 12, tzinfo=pytz.utc)
dd = Delorean(dt)
dt_eastern = dd.shift("US/Eastern").datetime
from delorean.
@myusuf3 No I've not come across anything else that's inconvenient, I'm really enjoying using Delorean. If it had a kwarg that took an aware datetime (ensuring anyone that used it is doing it intentionally) then that would be perfect!
from delorean.
@mwaterfall @fawce I have added support for dealing with already localized datetime objects. c6f4185
Hope this alleviates some pain with the library.
I would reread this section for the new functionality. http://delorean.readthedocs.org/en/latest/quickstart.html#making-some-time
from delorean.
Since my most common use is shift, I would prefer the time zone parameter to shift an aware date time rather than be ignored.
from delorean.
@fawce you can still shift after the object is created, but I guess I can update that caveat in an upcoming release.
from delorean.
@myusuf3 Awesome, thanks for incorporating this feature. Much appreciated :-)
from delorean.
Related Issues (20)
- Pip package is not updated HOT 2
- parse function does not parse date string correctly
- Publish New Version HOT 5
- Language support HOT 1
- Fix simple typo: specificed -> specified
- mistake in parse example HOT 1
- zoneinfo.ZoneInfo AttributeError while parsing within the Django context HOT 1
- mock requirement could be optional
- PytzUsageWarning "normalize method is no longer necessary" when using delorean.parse()
- #118
- Issue with tzlocal==5.0
- Fix midnight() and naive() references on Quickstart page HOT 2
- Strict ISO 8601 parser HOT 1
- Add a wrapper for babel's parse_pattern() HOT 2
- Delorean.now() accepts timezone while delorean.now() does not
- parser failling in RFC3339 format HOT 1
- delorean.dates.UTC is gone in 0.6.0
- Some kind of time delta for localized "business days"
- Delorean.shift does not take datetime.timezone.utc HOT 3
- stops() skips february??? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delorean.