Git Product home page Git Product logo

Comments (1)

mysticatea avatar mysticatea commented on June 15, 2024

Thank you for this issue.

The type definition is welcome.
I love TypeScript.

But I'm not sure if refactoring by TS has enough profits. This project and event-target-shim that this project depends have some codes that TS cannot express. For examples:

  • defineEventAttribute(proto, type) adds an instance property to the class of the proto.
  • AbortSignal's constructor must throw a TypeError always, but it can be instantiated from inside of AbortController implementation.

Additionally, I have a concern about class inheritance. AbortSignal inherits EventTarget, but people can use this package in Node.js program in JavaScript, so they might feel odd if they required lib.dom.d.ts in order to use this package.

from abort-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.