Git Product home page Git Product logo

Comments (6)

tayvano avatar tayvano commented on July 20, 2024

Any chance you have Chrome? I can definitely run some tests in the AM and see if I can determine what is happening and push a hotfix. I'm guessing it's just a random issue with FIrefox on Ubuntu - we've had a couple slightly similar ones

Can you do the same but have your console open and let me know if you can see any errors in there?

You can access your browser console from the menu: select "Browser Console" from the Web Developer submenu in the Firefox Menu (or Tools menu if you display the menu bar or are on OS X) or from the keyboard: press Ctrl+Shift+J (or Cmd+Shift+J on a Mac).

from etherwallet.

apmilen avatar apmilen commented on July 20, 2024

Chrome worked like a charm! Thanks for the tip 😄 I've attached the stacktrace that was logged when I killed the unresponsive script in FF.

error.txt

from etherwallet.

tayvano avatar tayvano commented on July 20, 2024

Reopening this as someone else just reported same thing. Firefox 45, Mac 10.11.

@kvhnuke is going to look into this

from etherwallet.

tayvano avatar tayvano commented on July 20, 2024

Issue is: Firefox has a shorter timeout period than Chrome. Mist hashes the keystore files something like 30k times and javascript isn't the most ideal way to handle decrypting it. Chrome seems to just take longer. Firefox gives you an unresponsive script error.

Temporary solution:

  • Add loading icons to buttons when you click them so at least you know it's doing something
  • Add warning for Firefox (and others?) that Mist keystore files may take a bit longer than expected to decrypt and to say "Wait" on the unresponsive script issue on firefox and eventually it will unlock.

Real solution:

  • See if we can change or implement a better way to handle decrypting that will avoid unresponsive script issue on those affected browsers. 😜

from etherwallet.

linagee avatar linagee commented on July 20, 2024

I think the easiest and most straightforward way to solve this is likely to switch from https://github.com/cryptocoinjs/scryptsy to https://github.com/dchest/scrypt-async-js

I don't know how difficult it would be, but this seems like a solved problem luckily, myetherwallet just has to implement/test/etc the different library.

https://github.com/kvhnuke/etherwallet/blob/d8fb316162b3fecce29bfd3be545e1921e76e72f/app/scripts/main.js#L19

It's probably not easy, but at least one step easier than trying to modify scryptsy to use setTImeouts, scrypt-async-js seems to do that already.

On some sort of callback, it would be nice to have a progress bar. (I've experienced the same strange "things just lock up for a few seconds" in Chrome.)

Sorry if this is a gross oversimplification. It's kind of like saying "you just have to replace your car engine with a new hopefully compatible car engine, instead of redesigning a car engine from scratch". 👍

(Also, assuming the delay is inside scrypt(), I'm 90% confident of this from the stacktrace.)

from etherwallet.

rkagerer avatar rkagerer commented on July 20, 2024

I had the same problem, using a more recent offline MEW (etherwallet-3.11.1.7) under Firefox. I followed these instructions to increase the script timeout to 100 (lower than that didn't finish - it's pretty old hardware).

from etherwallet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.