Not a big problem by any stretch, but looks a little funny. I've got

Note that this also reproduces <a class="issue-link js-issue-link" data-error-text="Fa

Generated code contains duplicate imports under certain circumstances about go-proto-validators HOT 5 OPEN

johanbrandhorst commented on July 3, 2024

Generated code contains duplicate imports under certain circumstances

from go-proto-validators.

Comments (5)

mwitkow commented on July 3, 2024

Can you provide a minimum repro case + protoc command?

from go-proto-validators.

johanbrandhorst commented on July 3, 2024

https://gist.github.com/johanbrandhorst/3729f49bf430e6c6fc38a45e72a63612

from go-proto-validators.

johanbrandhorst commented on July 3, 2024

Note that this also reproduces #8

from go-proto-validators.

mwitkow commented on July 3, 2024

The validator plugin doesn't even reference the type.

This looks like an error inside the gogo proto's Generator, where it double references the type. I think that may be happening inside GetFieldName:
generator.GetFieldName calls generator.GoType which for durations and times appends an import:

	case gogoproto.IsStdTime(field):
		g.customImports = append(g.customImports, "time")
		typ = "time.Time"
	case gogoproto.IsStdDuration(field):
		g.customImports = append(g.customImports, "time")
		typ = "time.Duration"
	}