Git Product home page Git Product logo

Comments (6)

AlekSi avatar AlekSi commented on July 23, 2024 1

\\ in .proto file generated valid regex in Go code. Maybe add that to documentation and close this issue?

from go-proto-validators.

erstaples avatar erstaples commented on July 23, 2024

I'm running into the same thing, but not using quotes gives me a different error:

pkg/proto/nks.proto:48:50: Error while parsing option value for "field": Expected string, got: /

Is there a fix for this?

from go-proto-validators.

Helcaraxan avatar Helcaraxan commented on July 23, 2024

Hello @chaoweili and @erstaples. I've only very recently picked up this repository for maintenance. I'll try to address this issue in the near term.

from go-proto-validators.

Helcaraxan avatar Helcaraxan commented on July 23, 2024

The quick fix in the mean time should be to specify your regex within back-ticks instead of double-quotes.

from go-proto-validators.

erstaples avatar erstaples commented on July 23, 2024

Thanks for the response, @Helcaraxan . That doesn't work for me, unfortunately. My compiler really wants those quotes:

builder_api/builder_api.proto:113:29: Error while parsing option value for "field": Expected string, got: `

Here's the field in question:

    string kubernetes_version = 8 [
        (validator.field) = { regex: `/^v[0-9]{1}\.[0-9]{1,2}\.[0-9]{1,2}$/` }
    ];

from go-proto-validators.

Helcaraxan avatar Helcaraxan commented on July 23, 2024

Reading your regular expression (RE) a few questions come to mind:

  • Why the / at the front and the head of the RE? The ^ and $ already express the need to match an entire line?
  • I believe that the following should work and give you the result you want:
    string kubernetes_version = 8 [
        (validator.field) = { regex: "^v[0-9]{1}\\.[0-9]{1,2}\\.[0-9]{1,2}$" }
    ];

Bear in mind that the string you provide in the regex validator is reused as is to instantiate a regexp.Regexp from the Go standard library so the RE should follow Go's RE syntax. Just wanted to make sure that was well understood, just in case. 🙂

from go-proto-validators.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.