Git Product home page Git Product logo

Comments (7)

mwaskom avatar mwaskom commented on June 5, 2024

Are you sure FSL does this? It's not mentioned in the FSL Design Matrix Rules http://fsl.fmrib.ox.ac.uk/fsl/fslwiki/FEAT/UserGuide#Appendix_B:_Design_Matrix_Rules

from moss.

iancballard avatar iancballard commented on June 5, 2024

Hmm, according to Jeanette Mumford they do, but you're right its not in the pseudo-code.

From http://journals.plos.org/plosone/article?id=10.1371/journal.pone.0126255

"Similar to SPM, FSL also allows for the modeling of temporal derivatives of regressors to account for minor timing misspecifications. FSL uses a slightly different orthgonalization strategy where the derivative is orthogonalized with respect to both the original regressor and the overall mean. As shown in [2], this approach may still be beneficial in improving the estimate for the regressor of interest, the original regressor, but not as beneficial as only orthogonalizing with respect to the original regressor, as done in SPM."

There's no mention of temporal derivatives in the release notes. I'll email the list.

from moss.

iancballard avatar iancballard commented on June 5, 2024

If you decide to change it, my solution was to add one line at line 65 (after scaling) of glm.py:

dy = dy - (np.dot(y,dy)/np.dot(y,y) * y) #orthogonalize

from moss.

mwaskom avatar mwaskom commented on June 5, 2024

You would at least want to make it optional for backwards compatibility. Also based on ad hoc checking on a couple runs of a simple design, the value of the correlations between an event-related regressor and its derivative is quite low (r < 0.02) so I doubt it makes a huge difference in practice even if it is the right thing to do.

from moss.

iancballard avatar iancballard commented on June 5, 2024

Agree it might not matter. It's hard to tell from the paper cited above. Anyways, FSL does orthogonalize:
https://www.jiscmail.ac.uk/cgi-bin/webadmin?A2=ind1608&L=FSL&P=R35561&1=FSL&9=A&J=on&d=No+Match%3BMatch%3BMatches&z=4

from moss.

mwaskom avatar mwaskom commented on June 5, 2024

It would be helpful if you could write back and ask what source code file one could read if they wanted to see exactly how it is done. :)

from moss.

iancballard avatar iancballard commented on June 5, 2024

Nothing too useful:
Hello,
$FSLDIR/src/feat5/feat_model.cc contains all the code for design generation/processing etc.
Kind Regards
Matthew

This code is no fun to read, but it looks like it happens with a comment saying: "// well, Timmy wanted it but doesn't seem to have much effect....."

So perhaps it doesn't matter after all.

from moss.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.