Dark and non-dark icons in the admin panel about nextcloud-breeze-dark HOT 18 CLOSED

Before I had a chance to do more in-depth testing the problem fixed itself on my personal instance, which validates my theory that it most likely is a caching issue.

from nextcloud-breeze-dark.

0 « root » /usr/share/webapps/nextcloud # sudo -u http ./occ maintenance:theme:update
The current PHP memory limit is below the recommended value of 512MB.
mimetypelist.js is updated
Image cache cleared

The result is still the same.

from nextcloud-breeze-dark.

Thanks a lot @tanghus

I'm not quite sure, if it's possible, at this time, but I would be interested in implementing it, if and/or when it's doable. I'll have a look and see what the options are.

I would greatly appreciate, if you opened a separate issue. It makes it easier to keep track of everything.

from nextcloud-breeze-dark.

Hi

I can't seems to reproduce the same problem, but I've noticed that the icons that are black are all icons that should be taken from the theme directly. The white icons are all icons I couldn't easily replace so I'm changing their color with CSS.

Have you disabled the theming app? The theming app is the only thing I know for sure causes this kind of problem with custom themes.

from nextcloud-breeze-dark.

Hi,

thanks for your answer. Yes, i've disabled the theming app since I first installed this theme - and I double checked that it is still not activated (so the nextcloud update did not activate it again).

from nextcloud-breeze-dark.

Okay, have you noticed any other places in Nextcloud where there are dark icons. I don't have a great understanding of the inner workings of how Nextcloud handles custom themes. Stuff like the details of exactly how Nextcloud handles replacing icons, because so far it has more or less worked. I have experienced issues like yours, but only while using my development setup, which I just reinstalled to fix it.

The main problem is there isn't really any good documentation on the more specific details for custom themes, and I sadly don't have time to dig through the code. Though there is one thing you could do that might be a help, if you inspect the HTML and let me know the source (src) of the dark icons.

I'll keep an eye out and see if I find something.

from nextcloud-breeze-dark.

Nextcloud 14.0.3 with theme version 14.0.2 from zip.
Click for screenshot.
The problem remains.

from nextcloud-breeze-dark.

Hi, thanks for the update.

First, have you tried clearing your browsers cache? See if that works. If not, could I ask you to open the HTML inspection tool and take a screenshot of the source of the image and the CSS that's applied to it. Then I can maybe figure out what's going on.

from nextcloud-breeze-dark.

Not sure which part of CSS you need. I'm not an expert in CSS, so you will have to be more specific.
I did take a screenshot though, not sure if it's helpful. Click.

from nextcloud-breeze-dark.

Thanks for the screenshot. I can see from it that Nextcloud is taking the icons from the wrong location. It's taking the icons from the app folder instead of from the theme, which is why it's black. I'm not sure of the reason for this as I don't know all the different things Nextcloud looks for to decide which icon to use. The only thing I'm certain of is when it works as intended icons from custom themes get priority.

You can try running the occ command maintenance:theme:update and see if that works.

from nextcloud-breeze-dark.

@mwalbeck thanks a lot, your command almost fixed the issue for me!

now there are only the icons for "external sites", "full text search" and bookmarks left black...

from nextcloud-breeze-dark.

The reason is because the icon in black are not being requested from the themes directory.

<a href="/settings/user/sharing">
<img alt="" src="/themes/nextcloud-breeze-dark/core/img/actions/share.svg">
<span>Sharing</span>

<a href="/settings/user/ojsxc">
<img alt="" src="/apps/ojsxc/img/app-black.svg">
<span>JavaScript XMPP Client</span>

Guess if the OCD is that unbearable you can manually edit those black icons to be white.

from nextcloud-breeze-dark.

Okay, a similar issue is now showing on my personal instance of Nextcloud so I can try to troubleshoot it a bit better. I have problems with the Favicon and the settings dropdown icons. What I've noticed so far with the favicon is, depending on which app I'm using, it switches back and forth between pulling the favicon from the theme and core.

from nextcloud-breeze-dark.

Nice work, but maybe color the icons with css

from nextcloud-breeze-dark.

A quick little update, I had this issue recently which I fixed by running the maintenance:repair occ command. Though be a bit a careful when using it, it seems to work fine with a standard install, but the docker image didn't like it. It seems the cache isn't regenerated properly in the docker image, but redoing the container should fix it.

from nextcloud-breeze-dark.

Great theme, @mwalbeck 👍
I just installed it, but now also notice, that the favicons shown are always the same standard Nextcloud icons, instead of the apps own icon. I have several Nextcloud tabs pinned in Firefox, so I only see the favicon, and this makes it difficult to tell which is which.

from nextcloud-breeze-dark.

I would greatly appreciate, if you opened a separate issue. It makes it easier to keep track of everything.

#76

from nextcloud-breeze-dark.

I'm going to close this issue as it's related to caching problems of image files. The versions for both NC17 and NC18 no longer use actual image files for icons, but everything is handled in CSS. You're very welcome to open up a new issue if any of you experience similar issues with the new versions of this theme.

from nextcloud-breeze-dark.