Wrong API id if id contains an angular expression about angular-pan-zoom HOT 5 CLOSED

I answer my own question: replacing this:

scope.elementId = element.attr('id');

with

scope.elementId = attrs['id']:

fixes the problem since attrs will contain the interpolated attribute.

from angular-pan-zoom.

Hi warpdesign,

Having both the problem and a one-line solution served on a silver platter makes for an excellent day in Developerville :-)

Thanks for pointing out the issue. I'll integrate the fix ASAP.

Cheers,
/Martin

from angular-pan-zoom.

Great! :)

Unfortunately I found other problems. Similar fix is needed in panzoomwidget directive, compile function:

panzoomId = tElement.attr('panzoom-id');

Again, this uses the non interpolated id. Problem is we do not have access to the interpolated value into the compile function.

I ended up using the pre/post functions to get the panzoomId. And I had to move the code from the controller into this function since controller method would be called before the pre/post functions, so before the pannzoomId is set.

In the end this is quite a lot of changes. If you want I could make a pull request with the changes.

from angular-pan-zoom.

Hi,

Thanks for your offer. A pull request would be much appreciated :)

Just out of curiousity .. do you use a large number of simultaneous panzoom directives on your page?

Cheers,
/Martin

from angular-pan-zoom.

Not a large number. I'd say we use 1-5 max panzoom directives.

I'll make a pull request later this week then :)

from angular-pan-zoom.