Comments (7)
Is it a common pattern for all unix tools that work with stdin/stdout to also accept files as arguments? I don't see why it shouldn't be supported, but just wondering.
I'm also thinking about multiple files. I'm guessing you would have xurls file1 file2
work just like cat file1 file2 | xurls
, as in without distinguishing files?
from xurls.
Also, of course the tool hanging when given an argument is a bug :)
from xurls.
Most (all?) of the *nix tools in the GNU Utils package that works on text works on files + stdin, cat, grep, more, less, tail ... So it's common. So common it was the first my fingers tried.
Ideally it should work like cat
does, so xurls file1 file2
xurls *.txt
etc should work (maybe spin up some Go routines to make it snappier).
from xurls.
Done. I've followed the pattern that cat
uses, explained in the commit for future reference.
from xurls.
I just noticed your mentioning of goroutines. For multiple files it could be used. They are cheap so that shouldn't be a problem, and it could indeed speed things up for large files or async I/O.
The only disadvantage I can think of is that the urls will no longer be output in the correct order like cat
prints the lines in order, even though at no point we say we're doing them in order.
from xurls.
The go routines would be a nice addon (not important), but is a different issue.
from xurls.
Could you please open a separate issue describing it?
from xurls.
Related Issues (20)
- generate: concurrent map write
- Managing duplicate URLs? HOT 4
- Email support HOT 6
- go: error loading module requirements HOT 3
- cmd/xurls: -fix eats input when URLs get longer
- avoid Relaxed from matching trailing TLDs without a word break HOT 2
- tag request HOT 1
- Static Urls HOT 1
- Issue with Email Addresses HOT 7
- [Bug] - Identifying tel:654654 as URL HOT 1
- go get -u ? HOT 1
- Relaxed mode is too relaxed HOT 3
- xurls does not recognize valid IRIs HOT 1
- authority component parsing does not align with RFC 3987 HOT 3
- make a deterministic variant of "go generate" and have CI check it's up to date HOT 1
- character ranges can optionally be limited to ascii HOT 2
- add a mode to only get relative urls? HOT 4
- Matches \r and \n as part of URL HOT 2
- Trailing colon not trimmed when using relaxed mode and no scheme HOT 1
- Relqxed does not recognized @! in the end of url
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xurls.