Git Product home page Git Product logo

Comments (6)

mvdan avatar mvdan commented on July 21, 2024

Thanks for raising this issue. It does look like there's an internal limit on the line length, which isn't ideal. I'll see what can be done.

from xurls.

mvdan avatar mvdan commented on July 21, 2024

I've verified that this fixes your example above. If you still run into issues, let me know.

The downside of the new approach is that if an input line is 1GB long, the program will allocate a lot of memory. But I don't think that's worse than erroring directly.

from xurls.

uggyuggy avatar uggyuggy commented on July 21, 2024

Thank you πŸ‘

from xurls.

uggyuggy avatar uggyuggy commented on July 21, 2024

Hi,
Thank's for code update. Error looks solved.

But it looks this commit introduce new "problem" with IDN TLD not matching anymore:

Before this commit:

πŸ‘‰ echo "test.网店" | ./xurls -r
test.网店
πŸ‘‰ 

After this commit:

πŸ‘‰ echo "test.网店" | ./xurls -r
πŸ‘‰ 

from xurls.

mvdan avatar mvdan commented on July 21, 2024

Thanks for noticing - not sure what happened there.

from xurls.

uggyuggy avatar uggyuggy commented on July 21, 2024

Thank you πŸ‘

from xurls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.