Git Product home page Git Product logo

Comments (17)

mvdan avatar mvdan commented on July 21, 2024

Regarding xurls-git - it used to exist, but I dropped it because changes have slowed down in the past year (the tool is mostly done).

As for source vs binary - having to install go to build is perhaps unnecessary, but I'd rather have this than have a PKGBUILD that just downloads and packages a binary. I prefer source builds, and I'm sure most people do too.

After all, go isn't that heavy (~160MB) and you can delete it right after the build. And you can already download the binary on your own if you wish.

I hope my reasoning makes sense. Even if I reintroduced xurls-git, I'd still keep xurls building from source.

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

An alternative would be to package it under xurls-bin, and there are ways of automating it if you don't want to release two packages continuously on every commit, e.g.: https://wiki.archlinux.org/index.php/Go_package_guidelines and https://github.com/seletskiy/go-makepkg

EDIT btw I just remembered that github has a fixed link on the latest release, could be useful

from xurls.

mvdan avatar mvdan commented on July 21, 2024

You're absolutely right, I hadn't considered that option.

I used to host the git repo on GitHub (mvdan/aur-xurls), but stopped doing that when AUR 4.0 was deployed and it could host the repo.

I'll push it to GitHub again and you can do the PR adding the -bin version in that repo. My understanding is that this can be done in a single PKGBUILD.

from xurls.

mvdan avatar mvdan commented on July 21, 2024

There: https://github.com/mvdan/aur-xurls

Close this issue once you open a PR. If you don't want to do a PR, I'll have to admit that I'm too lazy to look into this and won't do it myself.

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

No, the PKGBUILDs should be two, xurls and xurls-git, according to the specifications, but the cool thing is that you can automate the release packaging by using specific tools.

Are you sure you don't want to change the package's name?

For example you just have to commit to GitHub as you always did, and then just launch a command that will generate the updated PKGBUILD with the changed version and everything, and you can commit that changes automatically or manually to the AUR.

Why work when you can just automate and be lazy at the same time? :)

from xurls.

mvdan avatar mvdan commented on July 21, 2024

Hmm, I remember seeing instances of a single PKGBUILD generating multiple packages, but I can't find the keyword for that now.

I'll look into the tool and get back.

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

The -git version PKGBUILD doesn't have to be updated every time because it automatically retrieves informations from the git upstream repo, such as the version or tag. There should be a guide on git packages in the wiki.

As for the normal version, you should use the tool I suggested or similar projects. Hell, you can even automate it with shell scripts, pretty nice :)

Thank you!

EDIT yep, there it is https://wiki.archlinux.org/index.php/VCS_package_guidelines

from xurls.

mvdan avatar mvdan commented on July 21, 2024

Wait, you're confusing me. What I was going to look into is xurls-bin, not xurls-git.

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

ooh, ok, I may have misunderstood, could you explain better what would you like to have, please?

from xurls.

mvdan avatar mvdan commented on July 21, 2024

xurls tracking the latest stable and building it from source.
xurls-bin tracking the latest stable and downloading its binary from GitHub.

If I can accomplish that with small changes to my existing PKGBUILD, that's awesome. I'd rather do that than depend on a new tool to automate it, but that option is also OK.

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

OK, now that's clearer.
xurls's PKGBUILD should be OK, but I'm going to send a PR anyway to make sure it works without you updating the PKGBUILD every time.

As for xurls-bin (you'll have to create a new package in the AUR), you have to update its PKGBUILD every time you release a new version (in the Releases tab, the built ones) by the pkgver variable, and that's where the tool comes in, so you don't have to update it every single time, but it does it for you. You should read the README of the tool to find out how exactly it works.

Everything clear?

edit your PKGBUILD is already good actually, assuming you want to release a stable version.
That tool should take care of everything btw, play a little with it and see what you can do.
I'll send you the xurls-bin version in the meantime.

from xurls.

mvdan avatar mvdan commented on July 21, 2024

xurls's PKGBUILD should be OK, but I'm going to send a PR anyway to make sure it works without you updating the PKGBUILD every time.

Not sure what that PR will be like, so just file it and I'll review.

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

I noticed that the releases are not compiled, but are just a tarball of the source code :(
Can you compile and upload the latest release, please?
Thanks

from xurls.

mvdan avatar mvdan commented on July 21, 2024

Oh, this is just me getting mixed up, sorry. I do this for other Go projects of mine, like: https://github.com/mvdan/sh/releases

Will upload them now.

from xurls.

mvdan avatar mvdan commented on July 21, 2024

Done: https://github.com/mvdan/xurls/releases/tag/v1.1.0

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

Thank you!

from xurls.

pellettiero avatar pellettiero commented on July 21, 2024

Sorry to keep you waiting!
I sent a PR here: https://github.com/mvdan/aur-xurls/pull/1

from xurls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.