Gofumpt removing newlines before comments about gofumpt HOT 7 OPEN

Seems like this is happening specifically with the assignment := operator

from gofumpt.

This is also getting triggered JUST when the error is named err

from gofumpt.

According to the docs:

foo, err := processFoo()

if err != nil {
	return err
}

Will be always formatted to:

foo, err := processFoo()
if err != nil {
	return err
}

whether there is a comment or no I suppose

from gofumpt.

This is working as intended; see "No empty lines before a simple error check" in the README.

from gofumpt.

Well, maybe this can be changed for the case with comments? I understand that it's working as intended right now, but is there some huge problem with changing it? I could probably make a PR for the change

from gofumpt.

Personally I don't see the problem with removing empty lines when there are comments, but sure, I can review a PR.

from gofumpt.

I think this seems fine personally. The comment could be placed inside the block instead. On a simple error check, are you likely to be commenting something useful inbetween those lines too?

from gofumpt.