Git Product home page Git Product logo

Comments (3)

boris-il-forte avatar boris-il-forte commented on July 19, 2024 2

@RylanSchaeffer well, in theory, every deep actor-critic algorithm is already "broken" in the theoretical sense (most notably, the objective is maximizing the undiscounted state distribution instead of the discounted one).

However, if you share the weights, then the objective you are maximizing is not anymore the one presented in the papers. Plus, if you have a KL bound and you change arbitrarily your feature network, you may violate this KL bound (even in expectation!) if you are not careful enough in the implementation.

For this reason, we present the basic versions of the algorithm, as clean as possible and as sound as possible. Implementing a version that shares weights starting from our implementation should be pretty trivial, and we leave these practical use cases to the users.

Furthermore, in my research, I'm currently not much interested in learning continuous actions from pixels. As mushroom is a research tool, we focus principally on methods matching our research or general algorithms.

from mushroom-rl.

boris-il-forte avatar boris-il-forte commented on July 19, 2024

In theory, yes. We just never tried.
In practice, results may be worse than with other libraries, which allows sharing the network between the actor and the critic and update both simultaneously.
We will never implement network sharing, as it breaks most reinforcement learning algorithms. However, you can easily implement your favorite actor-critic with a mixed loss between value function target and policy target, exploring already existing implementations.

from mushroom-rl.

RylanSchaeffer avatar RylanSchaeffer commented on July 19, 2024

@boris-il-forte why does sharing (some) network between the actor and the critic break most RL algorithms?

from mushroom-rl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.