Unit testing: test_dork_links about glastopf HOT 4 CLOSED

Well it looks like I was intending to select from the dork db. IIRC this test was written last summer for vanilla installations with data imported into the events database. So that's probably why :)

In the end my database layout is pretty crappy. Many events have the same request path and could be linked into a dork database.

So don't save the request path to the events database but create a separate table with dorks and link them using a dork id. This would mean we have to look up the path in the dork db every time we see a request but we create way less redundant data. The same could be done with user_agent etc....

I'm not really a db guy so if this sounds totally non-sense, feel free to come up with something better!

By the way, any plans for non-relational databases?

from glastopf.

Okay, now it makes sense. I'll just refactor as needed :-)

After finishing implementation of sqlalchemy with the current "flat" db schema i might take a look at normalizing the schema.

In regards to non-relational databases the project might benefit from introducing a persistance facade, in that way we could parse the config file in one central location and avoid all the "if mongodb: ... else: ..." stuff..
This facade would have to be injected into classes as needed - which might also improve testability.

from glastopf.

Yeah, that sounds reasonable.

from glastopf.

Closing this one. sqlalchemy stuff is done, and tests are passing. The facade thingy, really belongs in a new issue.

from glastopf.