Git Product home page Git Product logo

Comments (4)

Muriel-Salvan avatar Muriel-Salvan commented on August 18, 2024

Hi

I haven't tested it on Rails 4 yet.

I just executed the test suite on Rails 3 and figured out that obsolete gems versions were causing the warnings you got. To get rid of them I had to bundle update before rake test.
I just committed the Gemfile.lock file with new gem versions. Maybe it will help you as the error you got looks more like a Rake compatibility problem.

However I also tried to change Rails version to 4.0.0 and the test suite failed miserably with another error on my side:

>rake test
DEPRECATION WARNING: config.whiny_nils option is deprecated and no longer works. (called from block in <top (required)> at /rails-ajax/test/dummy/config/environments/test.rb:15)
config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly:

  * development - set it to false
  * test - set it to false (unless you use a tool that preloads your test environment)
  * production - set it to true


You should not use the `match` method in your router without specifying an HTTP method.
If you want to expose your action to both GET and POST, add `via: [:get, :post]` option.
If you want to expose your action to GET, use `get` in the router:
  Instead of: match "controller#action"
  Do: get "controller#action" (RuntimeError)
C:/Ruby193/lib/ruby/gems/1.9.1/gems/actionpack-4.0.0/lib/action_dispatch/routing/mapper.rb:191:in `normalize_conditions!'

I foresee the following to ensure Rails 4 compatibility:
1- Migrate the Rails application used in the test suite from Rails 3 to Rails 4.
2- Adapt some rails-ajax methods: as rails-ajax deals with some Rails internals, I suspect some changes will be needed.

However rails-ajax code is quite simple, so the work should not be that hard.
I will try to figure this out as soon as I can.

I will keep this ticket to track migration. Thanks!

Cheers

Muriel

from rails-ajax.

LoveIsGrief avatar LoveIsGrief commented on August 18, 2024

Hello Muriel,

Thanks a lot for the quick a great news! We will gladly use and test your gem in our project once the migration has been completed.
We look forward to updates.

Cheers

from rails-ajax.

Muriel-Salvan avatar Muriel-Salvan commented on August 18, 2024

Rails 4 support has been added on bf37794.

rails-ajax 0.2.0 ships with Rails 4 support.

Thanks for your help

from rails-ajax.

LoveIsGrief avatar LoveIsGrief commented on August 18, 2024

That's great!

Thanks to you for the project and for integrating the changes :)
Cheers!

from rails-ajax.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.