Comments (5)
MineBill
commented on August 21, 2024
1
I would like to tackle this issue and implement the feature. This will be my first ever PR.
from mun.
Wodann
commented on August 21, 2024
Welcome and thank you for working on this PR. If you have any questions, please let us know.
from mun.
MineBill
commented on August 21, 2024
After implementing this, the following tests fail:
tests::abi_is_fresh
tests::runtime_capi_is_fresh
They require me to update the abi and the runtime-capi but doing so requires me to download both the ffi and the abi-c submodules. What should i do?
from mun.
Wodann
commented on August 21, 2024
You should always download the submodules, otherwise the tests will fail. Our install instructions describe how to do it, but it's just a single command:
git submodule update --init --recursivefrom mun.
Wodann
commented on August 21, 2024
Exemplary work! Really quick workflow from claiming the issue, to submitting a PR, and incorporating recommended changes. Well done 👍
We look forward to your next contribution
from mun.
Related Issues (20)
- Make the `layout` specific to primitives and structs HOT 2
- Merge example-rs into the main repo HOT 1
- "while"'s "break" could return value HOT 1
- Mun-Fork HOT 1
- Alternative codegen backend to make embedding possible HOT 1
- bump: upgrade to LLVM 14 HOT 2
- How to use with CMake
- `impl` blocks for struct functions
- Dynamic resizing of arrays
- Add hardware-generic Mun runtime performance tests
- Move `llvm-install` GitHub CI action to separate repo HOT 7
- Mun workspaces HOT 3
- Couldn't build mun from source HOT 2
- Upgrade LLVM to 15
- Upgrade LLVM to 16
- Can I call rust code in .mun? HOT 1
- Can't build from source HOT 3
- Missing Cargo.lock HOT 1
- Hot reload not working on Ubuntu WSL HOT 4
- Can't build mun_compiler + mun_runtime HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mun.