Comments (3)
hacst
commented on June 12, 2024
Hi. Your implementation isn't quite correct. For one it mixes usernames and channel ids which could be abused (though admittedly it's more of a correctness issue than a threat). On the other hand it uses the wrong location to prevent the plugin from acting. Where it is now if a user was moved to afk and hence muted & deafened by the plugin he would not get unmuted by leaving afk if he happened to join a whitelist channel.
#9 is my suggestion on how to do it. If you can verify it works (I currently don't have a stuff setup to test mumo properly) I can land it for everyone.
from mumo.
hamilton5
commented on June 12, 2024
Very cool, Thanks for taking the time to implement this (correctly) it seems to be working fine.
from mumo.
hacst
commented on June 12, 2024
Thanks for testing it. I landed the PR.
from mumo.
Related Issues (20)
- Mumo attaches callbacks multiple times when run for longer time HOT 2
- Test plugin calls nonexistent subscribeContextCallbacks method
- Idlemove.py is not moving the user back to the original channel HOT 2
- Not compatable with Debian 10 HOT 2
- Is it possible to update mumo to python 3? HOT 4
- Error running mumo HOT 3
- Can not start mumo HOT 2
- On Windows loadSlice failure, no information is printed HOT 1
- Mumo fails to load with Mumble 1.5 series
- Is mumo still alive? HOT 3
- Creating temporary channels HOT 7
- protocol error: out of bounds during unmarshaling HOT 2
- Mumo runs into RuntimeError; ends up not running HOT 8
- Fix for the dreaded mumo.pid.lock file bug HOT 11
- Cannot run docker container HOT 7
- [Request] accept unicode usernames HOT 1
- cannot start mumo probably a python problem HOT 1
- Daemon Not working correctly HOT 11
- syntax error HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mumo.