Git Product home page Git Product logo

Comments (11)

Jasper-MultiSafepay avatar Jasper-MultiSafepay commented on July 17, 2024 1

We released 1.6.0 which solves this issue.

from magento2msp.

Jasper-MultiSafepay avatar Jasper-MultiSafepay commented on July 17, 2024

@GuidoHub
We are investigating this.
On which version of Magento2 are you encountering this?

from magento2msp.

GuidoHub avatar GuidoHub commented on July 17, 2024

@Jasper-MultiSafepay It's on magento 2.1.14

from magento2msp.

Jasper-MultiSafepay avatar Jasper-MultiSafepay commented on July 17, 2024

Can reproduce this.
Being caused by context validation in Magento 2.1.x
This context validation is removed in Magento 2.2.x
Have added a solution to the current sprint of the plugin.
Sprint will be finished at the end of this month.
If needed I could make that branch public, so you can use the fix?

from magento2msp.

GuidoHub avatar GuidoHub commented on July 17, 2024

@Jasper-MultiSafepay , would be nice if you could make it public so I can use the fix.

from magento2msp.

Jasper-MultiSafepay avatar Jasper-MultiSafepay commented on July 17, 2024

@GuidoHub
Pushed branch 28c5836 for this compilation fix.
Will be added to the current sprint

from magento2msp.

hostep avatar hostep commented on July 17, 2024

@Jasper-MultiSafepay: wouldn't it make sense to release a hotfix where you include this fix, so a new version 1.5.2 with only the inclusion of this fix (if it is tested properly)?
I can imagine a lot of people updating to 1.5.1 running into this problem now. And waiting a full month for a fix is maybe a bit much?

(We haven't update ourselves yet, so I can't say if it will happen to us, but it sounds like it will when we do this on our Magento 2.1.x shops)

Thanks!

from magento2msp.

Jasper-MultiSafepay avatar Jasper-MultiSafepay commented on July 17, 2024

@hostep
I'll have to discuss this internally if that's possible

from magento2msp.

GuidoHub avatar GuidoHub commented on July 17, 2024

@hostep I think you should also look at this issue #74

from magento2msp.

Jasper-MultiSafepay avatar Jasper-MultiSafepay commented on July 17, 2024

@hostep
I have received feedback on your request for a hotfix release:
The timing between a seperate hotfix release and the current sprint would be too short as it includes more extensive testing.
The next version (which also includes fixes for #73, #74) will be released no later than 21-9.

from magento2msp.

hostep avatar hostep commented on July 17, 2024

Ok no problem, we'll hold of the upgrade for now on our 2.1 shops then.
Thanks for the feedback!

from magento2msp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.