Building with -buildmode=pie exposes crash in parquet test about dsq HOT 5 CLOSED

Hey I'm in luck, one of the contributors figured it out. goccy/go-json#350

However in looking at the go-json/issues I notice a few other panic issues. So I'm also going to institute a panic fallback to the standard library. It is going to make noticing this harder since dsq hides logs by default and even if it didn't you likely wouldn't look at logs if the program was successful.

But the most important thing is not crashing on valid input.

from dsq.

This originally showed up when I switched from 0.5.0 to 0.6.0 (and all later versions), and the commits between 0.5.0 and 0.6.0 make me think that the issue is probably further upstream in github.com/goccy/go-json, as that is a new dependency added to the go.mod file.

from dsq.

Yeah the panic is in that library but while I can reproduce it inside of dsq and DataStation I cannot reproduce it using the library alone (even though it's hard to understand how it's a purely datastation/dsq bug). So I can't make a good issue for goccy/go-json yet.

I can't spend much more time debugging this at the moment. If Arch users mention this panic I'm going to suggest they download an official binary instead of the Arch one since -buildmode=pie is not supported at the moment (although I'd like to support it in the future).

I'd welcome any fixes/suggestions anyone has to fix this here or in goccy/go-json.

from dsq.

Also posted it on Reddit to see if anything about this sounded familiar to others: https://www.reddit.com/r/golang/comments/th2p4y/runtime_panic_when_accessing_global_variable_only/.

from dsq.

Alright 0.8.1 is out now with the fix.

from dsq.