Git Product home page Git Product logo

Comments (5)

Stebalien avatar Stebalien commented on July 17, 2024 1

In principle, I agree. Given the number of dependencies on this package, we'd probably just create a new go-multihash-format package and create a bunch of type aliases.

However, we probably won't get around to doing this any time soon.

(although having something other than Sum really would be nice)

from go-multihash.

fjl avatar fjl commented on July 17, 2024

Also consider that Sum will never be enough: code that hashes data might want to reuse hash objects, write to them as a stream, etc.

from go-multihash.

Stebalien avatar Stebalien commented on July 17, 2024

Went looking for this and realized it was closed. This isn't fixed.

We should:

  1. Stop checking for "valid" codes. There's no reason to reject unknown codes.
  2. Move the core logic to a separate module.

That way, people can depend on the types when they don't really need to be able to hash things.

from go-multihash.

Stebalien avatar Stebalien commented on July 17, 2024

Visiting for triage, I'm closing this in favor of a new issue that succinctly describes the change we'd accept.

from go-multihash.

Stebalien avatar Stebalien commented on July 17, 2024

(the issue: #131)

from go-multihash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.