Git Product home page Git Product logo

Comments (10)

michaldudak avatar michaldudak commented on August 22, 2024 1

Sorry, I saw just the first link :/
The icons download script has a list of seemingly random exclusions (https://github.com/mui/material-ui/blob/next/packages/mui-icons-material/scripts/download.mjs#L14). I never fully understood the pattern here. I think it's safe to remove the emergency icon from this list and run the scripts again.

from material-ui.

CelestialWorthy avatar CelestialWorthy commented on August 22, 2024

emergency
something like this ?

from material-ui.

Justin-Luo avatar Justin-Luo commented on August 22, 2024

@CelestialWorthy no, this one from Material Icons

emergency_FILL0_wght400_GRAD0_opsz24

https://fonts.google.com/icons?selected=Material+Symbols+Outlined:emergency:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=emergency

from material-ui.

CelestialWorthy avatar CelestialWorthy commented on August 22, 2024

What is the naming convention for the icons? I saw that material icons contain svg icons so do i just import it there ?

from material-ui.

CelestialWorthy avatar CelestialWorthy commented on August 22, 2024

on another note , do you think it is possible to add car logos as icons ?

from material-ui.

Justin-Luo avatar Justin-Luo commented on August 22, 2024

Following up, is this something that can be added soon?

from material-ui.

Justin-Luo avatar Justin-Luo commented on August 22, 2024

@danilo-leal does your PR add the Emergency icon specifically?

https://fonts.google.com/icons?icon.set=Material+Icons&selected=Material+Icons+Outlined:emergency:&icon.query=emergency

from material-ui.

danilo-leal avatar danilo-leal commented on August 22, 2024

@Justin-Luo It should've been added, but looking back again, it doesn't seem like it has ๐Ÿค” I've seen other instances (#39874) where the script to update the Material Icons wasn't picking up every new icon available there. Any pointers @siriwatknp or @michaldudak?

from material-ui.

michaldudak avatar michaldudak commented on August 22, 2024

The icon @Justin-Luo linked to is from Material Symbols, not Material Icons. Our library mirrors Material Icons, which doesn't contain the Emergency icon. If you'd like it to, please open an issue in the Material Icons repo.

from material-ui.

danilo-leal avatar danilo-leal commented on August 22, 2024

๐Ÿคจ The icon he's linking is from Material Icons, though, not from Symbols. That's why I thought it should've been picked up.

https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Aemergency%3A

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.