Here is code: <div class="snippet-clipboard-content notranslate position-relative

What's up with the benchmarks? :( about avsc HOT 2 CLOSED

mtth commented on September 18, 2024

What's up with the benchmarks? :(

from avsc.

Comments (2)

mtth commented on September 18, 2024 1

There are several things wrong with your benchmark.

The first and most important is that you're not comparing equivalent operations: you should be comparing JSON.parse with type.toBuffer or type.encode. avro.parse generates a type from a schema, it's a pre-processing step which should only be done once per schema.

The other major problem is that micro-benchmarks are tricky to get right. v8 has many optimizations which can render your benchmark meaningless. If we tweak your code to remove any obvious pitfalls (see below), we get:

JSON: 2239ms
Avro: 2200ms

var avro = require('avsc');

var schema = {
  name: 'Pet',
  type: 'record',
  fields: [
    {name: 'kind', type: {name: 'Kind', type: 'enum', symbols: ['CAT', 'DOG']}},
    {name: 'age', type: 'int'} // To simplify preventing getting hoisted out of the loop.
  ]
};

var type = avro.parse(schema); // Done once upfront.

var start = Date.now();
for (var i = 0; i < 5000000; i++) {
  if (JSON.stringify({age: i, kind: 'CAT'}).length < 2) {
    throw new Error();
  }
}
var stop = Date.now();
console.log("\t      JSON: " + (stop - start) + "ms");

start = Date.now();
for (var i = 0; i < 5000000; i++) {
  if (type.toBuffer({age: i, kind: 'CAT'}).length < 2) {
    throw new Error();
  }
}
stop = Date.now();
console.log("\t      Avro: " + (stop - start) + "ms");