Odd behavior when using git URLs in pyproject.toml about poetry-dynamic-versioning HOT 6 CLOSED

Phew 😅 I did start looking into some better handling for this, by the way, but I've been a bit busy and haven't managed to finish it up yet. Hoping to have some news soon.

from poetry-dynamic-versioning.

Yeah this looks great now! ❤🤘
Thank you so much for fixing this!!

from poetry-dynamic-versioning.

Good find! That's a limitation of the current design, but I'll see if I can make it handle this better.

For reference, does this break anything for you? I can imagine that it would break any code that checks pkg2's version (e.g., enable a feature if it's new enough), but just want to make sure it's not worse than that.

from poetry-dynamic-versioning.

No it does not appear to break anything, but I haven't tried pointing to a specific commit. I am using the latest commit on master in my case, and this seems to work fine.

from poetry-dynamic-versioning.

Unfortunately I hit an issue in production which prevents me from using poetry-dynamic-versioning altogether:

Because pkg1 (1.2.1.dev0+gd3ce74c.d20200915054707) depends on pkg2 (1.2.1.dev0+gd3ce74c.d20200915054707 git)
 and pkg3 depends on pkg2 (3.1.2.dev0+gf0996b2.d20200914095735 url), pkg1 is forbidden.
So, because pkg3 depends on pkg1 (1.2.1.dev0+gd3ce74c.d20200915054707 git), version solving failed.

The pkg2 (3.1.2.dev0+gf0996b2.d20200914095735 url part refers to a wheel URL.

So, I am pretty sure that this actually embeds the wrong versions inside the metadata of a wheel. The wheel becomes incompatible with its sub-dependencies.

EDIT: Umm, wait. I think I have a circular dependency issue. Likely a false alarm!

from poetry-dynamic-versioning.

@fredrikaverpil This is now fixed in v0.9.0 of the plugin. Could you try it out and let me know if you still see any issues with this?

from poetry-dynamic-versioning.