Two concurrent requests to the same host override each other about interceptors HOT 7 CLOSED

This needs to be verified in an actual usage scenario.

from interceptors.

Does this affect only the headers? I am planning to use the library to intercept and log outgoing http requests. I have a single middleware function that logs the method and url.href and does not return a mocked response. Does this sound like a scenario that will encounter the issue, with a high enough volume of requests and possible matching urls?

Thank you for your advice.

from interceptors.

Hi, @sean-hernon. I believe the issue is related to subsequent requests to the same endpoint, not necessarily to headers. I haven't got a capacity to reproduce this, would you mind giving me a hand? If we can get a reliable reproduction repository where this issue occurs, we can track it down and find a solution.

from interceptors.

Hi @kettanaito yes I would certainly like to help when I get some free time.

In the case where no mocked response is returned, do you foresee that the issue will cause the real request to be corrupted? If two requests made to the same endpoint, but with different methods are issued, do you foresee any conflict there?

from interceptors.

I have tried to reproduce this issue, but have had no luck so far. Do you have any more information related to how you encountered the issue?

Edit: To be more specific, I have been able to reproduced the issue like this, using the usual helpers inside the tests -

test('two concurrent requests are processed independently', async () => {
  const requests = await Promise.all([
    prepare(
      httpRequest('http://httpbin.org/get'),
      pool
    ),
    prepare(
      httpRequest('http://httpbin.org/get', {
        headers: {
          foo: 'bar',
        },
      }),
      pool
    )
  ])

  expect(requests[1]?.headers).toHaveProperty('foo', 'bar')
})

But this is because prepare uses findRequest, which does not consider headers when looking-up the request in the pool. I wanted to check that the issue was not encountered in this manner.

from interceptors.

Thank you for assistance on this, @sean-hernon! Those insights are most useful.

Please, if you happen to reproduce it, could you submit a pull request with a failing test that does so? It doesn't have to contain a solution straight away, as a reliable reproduction would help us find one much faster. Thanks.

from interceptors.

@kettanaito Do you remember what you did exactly to see the issue? Was it exactly as in the steps to reproduce?

from interceptors.