Git Product home page Git Product logo

Comments (1)

vphantom avatar vphantom commented on May 20, 2024

I was able to make PP.pm pass test 21 by moving the B::SVp_NOK test below the B::SVp_IOK test, and augmenting the latter with a simple sanity check:

--- PP-orig.pm	2018-01-11 10:58:21.374129040 -0500
+++ PP.pm	2018-01-11 10:13:01.782109956 -0500
@@ -271,10 +271,7 @@
         return $header . $value;
 
     }
-    elsif( $flags & B::SVp_NOK ) { # double only
-        return pack_double( $value );
-    }
-    elsif ( $flags & B::SVp_IOK ) {
+    elsif ( $flags & B::SVp_IOK && $value == int($value) ) {
         if ($value >= 0) { # UV
             return    $value <= 127 ?    CORE::pack 'C',        $value
                     : $value < 2 **  8 ? CORE::pack 'CC', 0xcc, $value
@@ -290,6 +287,9 @@
                     : pack_int64( $value );
         }
     }
+    elsif( $flags & B::SVp_NOK ) { # double only
+        return pack_double( $value );
+    }
     else {
         _unexpected("data type %s", $b_obj);
     }

However, I am stumped as to how I could achieve the same result in pack.c, so this isn't worthy of a pull request. :(

from msgpack-perl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.