Comments (1)
I was able to make PP.pm
pass test 21 by moving the B::SVp_NOK
test below the B::SVp_IOK
test, and augmenting the latter with a simple sanity check:
--- PP-orig.pm 2018-01-11 10:58:21.374129040 -0500
+++ PP.pm 2018-01-11 10:13:01.782109956 -0500
@@ -271,10 +271,7 @@
return $header . $value;
}
- elsif( $flags & B::SVp_NOK ) { # double only
- return pack_double( $value );
- }
- elsif ( $flags & B::SVp_IOK ) {
+ elsif ( $flags & B::SVp_IOK && $value == int($value) ) {
if ($value >= 0) { # UV
return $value <= 127 ? CORE::pack 'C', $value
: $value < 2 ** 8 ? CORE::pack 'CC', 0xcc, $value
@@ -290,6 +287,9 @@
: pack_int64( $value );
}
}
+ elsif( $flags & B::SVp_NOK ) { # double only
+ return pack_double( $value );
+ }
else {
_unexpected("data type %s", $b_obj);
}
However, I am stumped as to how I could achieve the same result in pack.c
, so this isn't worthy of a pull request. :(
from msgpack-perl.
Related Issues (20)
- Cannot communicate with a Haskell based MsgPack RPC server HOT 5
- Invalid type 'Q' in pack at <...> HOT 9
- Minimal Perl version supported HOT 10
- failed test with perl5.19.1? HOT 6
- Use Types::Serialiser::Boolean for true/false HOT 5
- unpack with "extra bytes" HOT 2
- Problem parsing incoming data from Metasploit HOT 20
- Test failing on Mac with perl 5.22.0 HOT 10
- MessagePack working in a weird way. HOT 5
- No msgpack in alpine HOT 6
- New Str encoding broke compatibility with 0.49 decoding HOT 5
- Support IEEE 754 HOT 3
- Potential issue in casting numbers HOT 2
- Fails Makefile.PL with no '.' in @INC HOT 1
- Can't install under strawberry perl 5.30.0 HOT 3
- Hook for blessed variables HOT 1
- FAIL under -Dusequadmath HOT 1
- Deserialization Error with MessagePack JavaScript Libraries HOT 4
- trying to unpack MessagePack from C failing with "extra bytes (length should be 145)" message HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msgpack-perl.